Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin / languages : translate Rule to Czech Pravidlo in gherkin-languages.json #1442

Merged
merged 5 commits into from Apr 3, 2021

Conversation

plavcik
Copy link
Contributor

@plavcik plavcik commented Mar 25, 2021

Summary

translated Rule to Czech Pravidlo in gherkin-languages.json

Details

gherkin-languages.json adjusted

@aurelien-reeves
Copy link
Contributor

Thanks for your contribution @plavcik!

Could you please distribute the changes to the different parser implementations?

To do so, from within the docker image (make docker-run), in /app/gherkin:

source ../scripts/functions.sh
rsync_files
make clean
make

That should sync gherkin-languages.json in the different implementations and then fix the CI

@plavcik
Copy link
Contributor Author

plavcik commented Mar 27, 2021

That should sync gherkin-languages.json in the different implementations and then fix the CI

Getting error in part make. Will return to it later.

> @cucumber/gherkin@18.0.0 test
> mocha

sh: 1: mocha: not found
npm ERR! code 127
npm ERR! path /app/gherkin/javascript
npm ERR! command failed
npm ERR! command sh -c mocha

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add an entry under the "Fixed" header:

https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md

@plavcik
Copy link
Contributor Author

plavcik commented Apr 3, 2021

LGTM but please add an entry under the "Fixed" header:

https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md

Not sure, what to put there. Could you help me?

@aslakhellesoy aslakhellesoy merged commit 8559082 into cucumber:master Apr 3, 2021
@aslakhellesoy
Copy link
Contributor

Hi @plavcik,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants