Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Dado que" to Spanish translation for "Given" #188

Closed
wants to merge 1 commit into from

Commits on Apr 21, 2017

  1. Add "Dado que" to Spanish translation for "Given"

    "Dado que" is a better translation in Spanish for the "Given" word than "Dado" is. Also, the use of the current translation, "Dado", in Spanish generates a lot of duplication in steps.
    
    In the following example:
    
    Scenario: eat 5 out of 12
      Given there are 12 cucumbers
      When I eat 5 cucumbers
      Then I should have 7 cucumbers
    
    The Spanish translation with the current translation is the following:
    
    Escenario: me como 5 de 12
      Dado que hay 12 pepinos
      Cuando me como 5 pepinos
      Entonces debería tener 7 pepinos
    
    Initially you may think "Dado" is the right choice for the translation, but is not the case. In English you can swap any of the steps without any problem, but in Spanish you can't.
    
    Given there are 12 cucumbers == When there are 12 cucumbers == Then there are 12 cucumbers
    Given I eat 5 cucumbers == When I eat 5 cucumbers == Then I eat 5 cucumbers
    Given I should have 7 cucumbers == When I should have 7 cucumbers == Then I should have 7 cucumbers
    
    But in Spanish this is not the case, we can't swap the steps without making new steps:
    
    Dado que hay 12 pepinos != Cuando que hay 12 pepinos != Entonces que hay 12 pepinos (This makes no sense)
    Dado me como 5 pepinos (The right way is "Dado que me com...") != Cuando me como 5 pepinos == Entonces me como 5 pepinos
    Dado debería tener 7 pepinos (The right way is "Dado que deb...") != Cuando debería tener 7 pepinos == Entonces debería tener 7 pepinos
    
    Given that "Dado que" works most of the time, but "Dado" works sometimes as well, my proposal is to add "Dado que" and maintain "Dado" in the translations list.
    
    Thank you.
    
    Best regards,
    Roberto
    nilp0inter committed Apr 21, 2017
    Copy the full SHA
    8d5fd43 View commit details
    Browse the repository at this point in the history