Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gherkin: (JavaScript) Don't depend on fs in the library #196

Merged
merged 1 commit into from May 3, 2017
Merged

gherkin: (JavaScript) Don't depend on fs in the library #196

merged 1 commit into from May 3, 2017

Conversation

aslakhellesoy
Copy link
Contributor

Summary

Remove dependency on Node's fs library

Details

Only bin/gherkin depends on fs

Motivation and Context

There is no fs in the browser

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aslakhellesoy aslakhellesoy merged commit c3b5599 into master May 3, 2017
aslakhellesoy added a commit that referenced this pull request May 3, 2017
@aslakhellesoy
gherkin: Attribution for #196
c112fec
@aslakhellesoy aslakhellesoy deleted the gherkin-javascript-no-fs branch July 12, 2018 21:14
@lock
Copy link

lock bot commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
language: javascript library: gherkin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aslakhellesoy