Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin: Retain leading and trailing newlines in data table cells #293

Closed
wants to merge 2 commits into from

Conversation

brasmusson
Copy link
Contributor

Summary

Do not trim leading and trailing newlines, that is "\n" converted to newline, in data table cells.

Details

Trimming leading and trailing newlines in data table cells is a regression compared to Gherkin v2.

  • C
  • .NET
  • Go
  • Java
  • Javascript
  • Objective-C
  • Ruby
  • Perl
  • Python

Motivation and Context

Fixes #290.

How Has This Been Tested?

The acceptance test has been updated to verify this behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Leading and trailing newlines, that is "\n" converted to newline,
should not be trimmed in data table cells.
@stale
Copy link

stale bot commented Dec 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 22, 2017
@brasmusson brasmusson added the 🧷 pinned Tells Stalebot not to close this issue label Dec 26, 2017
@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 26, 2017
@aslakhellesoy
Copy link
Contributor

This has gone stale in the light of #425. It would be cool to have this implemented in the Gherkin-Go, but that should be done in a new PR.

@aslakhellesoy aslakhellesoy deleted the gherkin-retain-newline-in-cells branch July 12, 2018 21:12
@lock
Copy link

lock bot commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library: gherkin 🧷 pinned Tells Stalebot not to close this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gherkin: Leading and trailing "\n" are trimmed in DataTable cells
2 participants