Leading Tab characters break parser logic

[VjacheslavVytjagov]

Leading Tab characters is kept in the trimmed_line and
GherkinLine_start_with can't recognize keywords in this case

Summary

If a feature file uses Tab character for indentation then the parser build incorrect AST: nothing keywords will not be detected in the text with indentation.

Details

I'v modified GherkinLine_new to remove leading Tab characters in the trimmed_line field as well as whitespaces.

Motivation and Context

Our editor allows to use Tab characters. In this case we had invalid AST.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[aslakhellesoy]

LGTM! @brasmusson or @cyocum feel free to merge and update CHANGELOG

[aslakhellesoy]

Hi @VjacheslavVytjagov,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.