Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badeball restore native javascript gherkin #709

Merged
merged 18 commits into from Sep 25, 2019
Merged

Badeball restore native javascript gherkin #709

merged 18 commits into from Sep 25, 2019

Conversation

aslakhellesoy
Copy link
Contributor

Builds on #689 and ports everything to TypeScript. -And various other improvements (aligning more with the Ruby implementation)

badeball and others added 17 commits August 26, 2019 00:28
@badeball
Initial work on restoring the native parser
a8ae004 
This is essentially a checkout of the parser as of #353. I've scoped the
content to src/legacy for now.

[1] #353
@badeball
Wire the legacy implementation to the build
043d07d 
This entails exporting it, adding a flag, and as well as making some
small changes to Makefile, etc.
@badeball
Update the legacy implementation to satisfy all tests
8b6d9ef
@badeball
Convert legacy tests to TypeScript
29c28c2 
This is just the minimum require change to make them accepted by the
TypeScript compiler.
@aslakhellesoy
Merge with master. Fix Makefile dependencies.
ee83195
@aslakhellesoy
WIP
1e035c4
@aslakhellesoy
More realistic random results
a985c91
@aslakhellesoy
Release fake-cucumber v1.1.1
33537f4
@aslakhellesoy
Merge branch 'master' into badeball-restore-native-javascript-gherkin
d4b7155
@aslakhellesoy
WIP
f80adf8
@aslakhellesoy
Merge branch 'master' into badeball-restore-native-javascript-gherkin
b6519e9
@aslakhellesoy
Merge remote-tracking branch 'origin/master' into badeball-restore-na…
e34fbfe 
…tive-javascript-gherkin
@aslakhellesoy
Make gherkin TypeScript tests pass. Align with Ruby implementation.
74ca3c8
@aslakhellesoy
Update fake-cucumber
5e14ca6
@aslakhellesoy
rsync
0f97fcf
@aslakhellesoy
Make gherkin-js work with external executable
03d20db
@aslakhellesoy
Circle build no longer depends on c21e-javascript
1afd5d0
@aslakhellesoy aslakhellesoy merged commit ef03431 into master Sep 25, 2019
@aslakhellesoy aslakhellesoy deleted the badeball-restore-native-javascript-gherkin branch September 25, 2019 07:39
@badeball badeball mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
language: javascript library: gherkin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslakhellesoy @badeball