tag-expressions: (Java) Make the jar a bundle to support osgi. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwynne
changed the title
|
@aslakhellesoy @brasmusson how do we get this released? Who will take responsibility for doing it? |
|
@mattwynne please always update the History/CHANGELOG when you merge a PR - otherwise consumers have a hard time knowing what's new in a given release. In this case, tag-expressions doesn't even have a change log, so that needs to be added too. |
|
@aslakhellesoy noted. Are you able to make a release? Is seems a lot of other stuff depends on this. |
|
I'll make a release when I find some spare cycles. |
1 task
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build the tag-expressions jar as a OSGi bundle.
Details
bundlemaven-bundle-pluginto create the manifest according to the OSGi requirement.Motivation and Context
cucumber/cucumber-jvm#873 added support to execute Cucumber-JVM in OSGi containers. To not lose that ability when using the tag-expression library in Cucumber-JVM, the tag-expressions jar need to be built as an OSGi bundle.
How Has This Been Tested?
I have locally run the pax-exam example of Cucumber-JVM, which exemplifies testing OSGi bundles, successfully with these changes.
Types of changes