Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: Tests failing with older versions of Cucumber::Messages #48

Closed
andk opened this issue Nov 11, 2022 · 1 comment · Fixed by #50
Closed

perl: Tests failing with older versions of Cucumber::Messages #48

andk opened this issue Nov 11, 2022 · 1 comment · Fixed by #50

Comments

@andk
Copy link

andk commented Nov 11, 2022

👓 What did you see?

Sample fail report: http://www.cpantesters.org/cpan/report/08d0a464-6088-11ed-b801-d0c71a9a9636

✅ What did you expect to see?

Passing tests :)

🔬 How could we reproduce it?

I got fails with Cucumber::Messages 18.0.0. and 17.1.0 and got passes with 19.0.0 upwards.

Possible fix

I suppose you could either declare 19.0.0 as minimum version required or adjust the test for older versions.
@mpkorstanje mpkorstanje transferred this issue from cucumber/common Nov 11, 2022
@mpkorstanje mpkorstanje changed the title Tests failing with older versions of Cucumber::Messages perl: Tests failing with older versions of Cucumber::Messages Nov 11, 2022
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 11, 2022 •
edited

This is kinda cool. Unfortunately the automated email was aimed at a bot and no meaningful communication took place. 😄

Would it be possible to receive future reports in GitHub automatically?

mpkorstanje added a commit that referenced this issue Nov 11, 2022
@mpkorstanje
perl: Use version range for messages
c706f36 
We did not specify a version range for the Cucumber::Messages dependency. This
wasn't a problem before, every version of message was usable. However once
cucumber/common#1741 was merged this was no longer
true.

Fixes #48
@mpkorstanje mpkorstanje mentioned this issue Nov 11, 2022
Merged
7 tasks
mpkorstanje added a commit that referenced this issue Nov 11, 2022
@mpkorstanje
perl: Use version range for messages
f5b7b06 
We did not specify a version range for the Cucumber::Messages dependency. This
wasn't a problem before, every version of message was usable. However once
cucumber/common#1741 was merged this was no longer
true.

Fixes #48
mpkorstanje added a commit that referenced this issue Dec 2, 2022
@mpkorstanje
perl: Use version range for messages (#50)
f818210 
We did not specify a version range for the Cucumber::Messages dependency. This
wasn't a problem before, every version of message was usable. However once
cucumber/common#1741 was merged this was no longer
true.

Fixes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perl: Use version range for messages cucumber/gherkin
2 participants
@andk @mpkorstanje