Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider to allow to return errors in hooks #13

Closed
l3pp4rd opened this issue Jul 11, 2015 · 1 comment
Closed

consider to allow to return errors in hooks #13

l3pp4rd opened this issue Jul 11, 2015 · 1 comment

Comments

@l3pp4rd
Copy link
Member

l3pp4rd commented Jul 11, 2015

The only meaningful option now is to panic, would be better to handle errors for the suite correctly and the golang way
@l3pp4rd l3pp4rd added this to the Barristan Selmy - 0.3.0 milestone Jul 11, 2015
@l3pp4rd l3pp4rd changed the title consider to allow return errors before and after scenario, steps consider to allow to return errors in hooks Jan 19, 2016
@l3pp4rd l3pp4rd mentioned this issue Jan 19, 2016
Closed
@l3pp4rd l3pp4rd removed this from the 0.3.0 milestone Jan 25, 2016
@l3pp4rd
Copy link
Member Author

l3pp4rd commented Jan 25, 2016

on the other hand, it does not make sense to continue to run tests as these callbacks are used to control/reset state. Panics in this case, would pop more details regarding the cause of state failure. Leaving this open until there are better ideas

@l3pp4rd l3pp4rd closed this as completed Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@l3pp4rd