Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using latest gherkin-go is broken #17

Closed
odacremolbap opened this issue Mar 2, 2016 · 3 comments
Closed

Build using latest gherkin-go is broken #17

odacremolbap opened this issue Mar 2, 2016 · 3 comments

Comments

@odacremolbap
Copy link

2 days ago gherkin-go updated some types declared at ast.go

ScenarioOutline.Examples is now an []interface{}
https://github.com/cucumber/gherkin-go/blob/master/ast.go#L46-L50

type ScenarioOutline struct {
    ScenarioDefinition
    Tags     []*Tag        `json:"tags"`
    Examples []interface{} `json:"examples"`
}

Code that uses Examples is now failing due to not recognised methods.

Scenario:

godog$ git rev-parse HEAD
38c79db503ff4ad0cbb7c1fd04531f243d992c7d
gherkin-go$  git rev-parse HEAD
64f5ebccd5511abba41bf4fa5664faf289c9b102

go versions tested
osx (1.4.3, 1.5.0, 1.6.0)
alpine docker container (1.4.3)

Build output:

/go/src/github.com/DATA-DOG/godog # go build .
# github.com/DATA-DOG/godog
./fmt.go:224: ex.TableBody undefined (type interface {} has no field or method TableBody)
./fmt_pretty.go:136: example.TableBody undefined (type interface {} has no field or method TableBody)
./fmt_pretty.go:176: example.TableHeader undefined (type interface {} has no field or method TableHeader)
./fmt_pretty.go:181: example.Keyword undefined (type interface {} has no field or method Keyword)
./fmt_pretty.go:181: example.Name undefined (type interface {} has no field or method Name)
./fmt_pretty.go:183: example.TableHeader undefined (type interface {} has no field or method TableHeader)
./fmt_pretty.go:190: example.TableBody undefined (type interface {} has no field or method TableBody)
./suite.go:271: example.TableHeader undefined (type interface {} has no field or method TableHeader)
./suite.go:272: example.TableBody undefined (type interface {} has no field or method TableBody)
./suite.go:272: too many errors
@l3pp4rd
Copy link
Member

l3pp4rd commented Mar 2, 2016

indeed, will need to adapt it, thanks for the update

@odacremolbap
Copy link
Author

I'm sending a PR in a few seconds to add godep linked to the previous gherkin-go commit.
Testing right now.

@l3pp4rd
Copy link
Member

l3pp4rd commented Mar 2, 2016

the master was updated with gopkg.in release tag based package dependency. will need to follow it up with gherkin-go to next releases whether it will follow semver or not

@l3pp4rd l3pp4rd closed this as completed Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants