Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from go lint to staticcheck.io #448

Closed
carleeto opened this issue Dec 14, 2021 · 1 comment · Fixed by #457
Closed

Switch from go lint to staticcheck.io #448

carleeto opened this issue Dec 14, 2021 · 1 comment · Fixed by #457

Comments

@carleeto
Copy link
Contributor

Since go lint has been deprecated (golang/go#38968), it would be good to move to an actively maintained static checker for Go. staticcheck.io comes highly recommended and is sponsored by Google.

I would like to submit a PR in the future to implement this, but would like some feedback on whether this would be appreciated before I start.

@mxygem
Copy link
Member

mxygem commented Dec 14, 2021

I'm not familiar with staticcheck but I do know of a few teams that utilize golangci-lint as their choice. There's an option within VSCode's Go extension to select which linter to use and in checking the options just now, it looks like the newest VSC may have changed to defaulting to staticcheck.

Since not everyone uses VSCode, I'd absolutely appreciate bringing the project to a point where it is up to date and standardized for everyone. Thank you for reaching out about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants