Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code coverage? #56

Closed
gliptak opened this issue Dec 3, 2016 · 5 comments
Closed

code coverage? #56

gliptak opened this issue Dec 3, 2016 · 5 comments

Comments

@gliptak
Copy link

gliptak commented Dec 3, 2016

Would you be interested in a code coverage PR? The numbers are very low:

https://codecov.io/gh/gliptak/godog/branch/codecov1

Maybe I'm missing some test executions?
@l3pp4rd
Copy link
Member

l3pp4rd commented Dec 3, 2016

godog is tested by godog, it was not using go test command to run features by default, since I need to test the godog command itself.

The actual coverage: https://codecov.io/gh/DATA-DOG/godog/branch/codecov

@gliptak
Copy link
Author

gliptak commented Dec 3, 2016

Thanks for the pointer. Wrapping the godog run into a unittest is a good way to bring it under a single umbrella.

@gliptak gliptak closed this as completed Dec 3, 2016
@gliptak
Copy link
Author

gliptak commented Dec 7, 2016

@l3pp4rd Are you merging codecov to master soon? Thanks

@l3pp4rd
Copy link
Member

l3pp4rd commented Dec 7, 2016

yes, have added it in master

@gliptak
Copy link
Author

gliptak commented Dec 7, 2016

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gliptak @l3pp4rd