Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables with CJK characters do not align #99

Closed
pkufranky opened this issue Aug 22, 2022 · 2 comments Β· Fixed by cucumber/gherkin-utils#53
Closed

Tables with CJK characters do not align #99

pkufranky opened this issue Aug 22, 2022 · 2 comments Β· Fixed by cucumber/gherkin-utils#53
Assignees
Labels
πŸ› bug Defect / Bug good first issue Good for newcomers

Comments

@pkufranky
Copy link

πŸ‘“ What did you see?

When having CJK characters in table, table is not aligned after formatting.

βœ… What did you expect to see?

The table should be aligned, one cjk character should be calculated as two spaces instead of one.

πŸ“¦ Which tool/library version are you using?

cucumber vscode extension, 1.2.8

πŸ”¬ How could we reproduce it?

πŸ“š Any additional context?

expected:
image

actual:
image


This text was originally generated from a template, then edited by hand. You can modify the template here.

@pkufranky
Copy link
Author

pkufranky commented Oct 26, 2022

btw. The "Cucumber (Gherkin) Full Support" extension just does the right thing.

@kieran-ryan kieran-ryan added the πŸ› bug Defect / Bug label Dec 3, 2023
@kieran-ryan kieran-ryan changed the title table not aligned when having CJK characters Tables with CJK characters do not align Jan 2, 2024
@kieran-ryan kieran-ryan added the good first issue Good for newcomers label Jan 3, 2024
@kieran-ryan kieran-ryan self-assigned this Jan 20, 2024
@kieran-ryan
Copy link
Sponsor Member

Thanks so much for contributing this issue @pkufranky! πŸŽ‰ A fix has been implemented in the gherkin formatter package and will be available in a coming release once we propagate the change to this extension. Welcome any further contributions - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants