Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats settings #30

Closed
GoogleCodeExporter opened this issue Jul 15, 2015 · 3 comments
Closed

stats settings #30

GoogleCodeExporter opened this issue Jul 15, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

  I've been thinking about a "stats settings" that effectively dumps
the settings struct.  It helps in those cases where someone is asking
questions and you want to know something about their config.

  It also helped to write tests for the -C and -b: arguments that got
messed up specifically (as pointed out by Clint Webb).  I was able to
write a simple startup test that verifies that -C properly sets the
CAS setting where we want it, and -b: properly sets the tcp backlog
where we want it.

  stats settings, documentation and tests are in my stats_settings
branch and visible here:

    http://github.com/dustin/memcached/commit/0a83f5235d754543f602bc1aa67...

  The option tests and fixes are here:

    http://github.com/dustin/memcached/commit/d038aa38b8bfc4ae5abbe007929...

  In introducing these, I noticed that we are a bit hopeful in buffer
sizes when processing stats (as we need to do proper protocol-specific
termination).  Overall, I think the stats code may need a bit of work
to be safer, but this particular code is no worse. 

Original issue reported on code.google.com by dsalli...@gmail.com on 18 Mar 2009 at 7:07

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by dsalli...@gmail.com on 18 Mar 2009 at 7:17

  • Changed state: Started

@GoogleCodeExporter
Copy link
Contributor Author

I've been rebasing this as master moved, but the latest can always be found 
here:

http://github.com/dustin/memcached/commits/stats_settings

Original comment by dsalli...@gmail.com on 19 Mar 2009 at 9:18

@GoogleCodeExporter
Copy link
Contributor Author

Trond gave me some good review feedback on this.

Original comment by dsalli...@gmail.com on 19 Mar 2009 at 10:43

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant