Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ofxOfeliaLua for Lua 5.4.6 #85

Closed
Jonathhhan opened this issue Nov 7, 2023 · 7 comments
Closed

Update ofxOfeliaLua for Lua 5.4.6 #85

Jonathhhan opened this issue Nov 7, 2023 · 7 comments

Comments

@Jonathhhan
Copy link
Collaborator

Jonathhhan commented Nov 7, 2023

The updated ofxLua works with ofxOfelia, if I downgrade the included Lua to 5.3.6.
And I wonder how to change ofxOfeliaLua.cpp for make it work with Lua 5.4.6: https://github.com/cuinjune/Ofelia/blob/master/src/ofxOfeliaLua.cpp

@danomatika
Copy link

danomatika commented Nov 15, 2023

What is the actual issue beyond "it works with version A and not version B"? What do you mean by "works" or "doesn't work", there is no info. Is there a build error, runtime, error etc...

@Jonathhhan
Copy link
Collaborator Author

@danomatika sorry, that was not clear. Sound is still there, but just a grey screen. Strangely there is no error message...

@danomatika
Copy link

Ok, I can't help with anything specific to Ofelia. I was thinking it's a build issue with ofxLua.

@Jonathhhan
Copy link
Collaborator Author

Jonathhhan commented Nov 15, 2023

No, its specific to Ofelia. It just depends on the Lua lib that is included in ofxLua.

@Jonathhhan
Copy link
Collaborator Author

@cuinjune do you have any idea how to make ofxOfelia compatible with Lua 5.4.6 (current ofxLua)? Thanks.

@Jonathhhan
Copy link
Collaborator Author

This PR #86 seems to solve the issue.

@danomatika
Copy link

Another approach to this is to check the Lua version and conditionally define things that might have been removed: https://github.com/danomatika/ofxLua/blob/master/src/ofxLua.h#L34

Also, you can check if the define exists and define it if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants