Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML not parsed in nested book sections #7

Closed
andswitch opened this issue Jul 12, 2022 · 5 comments
Closed

UML not parsed in nested book sections #7

andswitch opened this issue Jul 12, 2022 · 5 comments

Comments

@andswitch
Copy link
Contributor

It looks like UML is not being parsed in nested book sections.

At first glance it works, however after closing and reopening a UML book, only the UML in the top-level sections are images.

@mmontone
Copy link
Member

Ohh. That's interesting ... I can't think of why that's happening .. I'll have a look soon.

@mmontone
Copy link
Member

Maybe this is a deeper problem? Have you tried your math and plot stuff in non top-level sections?

@andswitch
Copy link
Contributor Author

andswitch commented Jul 12, 2022

Maybe this is a deeper problem? Have you tried your math and plot stuff in non top-level sections?

Indeed, I haven't tried that

/edit: just tried it. Exact same problem with formulas and plots.

/edit: so the explorer shows that the parsers in the documents of the subsections are not of the right class

@andswitch
Copy link
Contributor Author

andswitch commented Jul 12, 2022

I fixed the problem in my image by moving the last statement of EruditeBookSection>>subsections: to EruditeBookSection>>parent: as the last statement.

This one: subsections do: [ :ss | ss parent: self ].

I don't have time to create a PR right now. I can do it later.

mmontone added a commit that referenced this issue Jul 13, 2022
@mmontone
Copy link
Member

I've applied your fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants