Add .js to cjs module id if needed for cram #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, @gehan. Let's rebase this on the dev branch and prepare for a 0.7.6 release. Thanks! |
|
I did this off master. I did a rebase but said everything is up-to-date. I didn't update any tests by the way! In case this hits any |
|
|
||
| return { | ||
| compile: function (pluginId, resId, req, io, config) { | ||
| var moduleId = resId; | ||
| if (resId.substr(resId.length - 3) !== ".js") { |
There was a problem hiding this comment.
This is actually a symptom of a bigger problem with file extensions iiuc, but let's go with this for now.
|
Cool. There's a way to switch the PR to dev instead of master. If you do that, I'll merge this in to dev asap. |
|
Can't seem to change the target - made a new pull req! #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.