Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guidelines #416

Closed
M-Pixel opened this issue Mar 4, 2017 · 6 comments
Closed

Contributing guidelines #416

M-Pixel opened this issue Mar 4, 2017 · 6 comments

Comments

@M-Pixel
Copy link

M-Pixel commented Mar 4, 2017

Please provide documentation (step by step walkthrough from scratch to PR) indicating how to contribute to this project.

Simply cloning, I was unable to install dependencies or run unit tests without errors.
@M-Pixel M-Pixel mentioned this issue Mar 4, 2017
Open
@davidchase
Copy link
Collaborator

@M-Pixel thanks for the issue, out of curiosity can you please provide what errors you encountered when trying to install dependencies and/or run the unit tests?

@M-Pixel
Copy link
Author

M-Pixel commented Mar 4, 2017 •
edited

Build Errors

> contextify@0.1.15 install C:\Users\Max\Code\Forks\most-domless\node_modules\contextify
> node-gyp rebuild


C:\Users\Max\Code\Forks\most-domless\node_modules\contextify>if not defined npm_config_node_gyp (node "C:\Users\Max\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else
(node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  contextify.cc
  win_delay_load_hook.cc
..\src\contextify.cc(150): error C2039: 'SetAccessCheckCallbacks': is not a member of 'v8::ObjectTemplate' [C:\Users\Max\Code\Forks\most-domless\node_modules\contextify\build\contextify.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(4696): note: see declaration of 'v8::ObjectTemplate'
..\src\contextify.cc(131): warning C4996: 'v8::Function::NewInstance': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\contextify\build\contextify.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(3292): note: see declaration of 'v8::Function::NewInstance'
..\src\contextify.cc(182): warning C4996: 'v8::Object::GetRealNamedProperty': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\contextify\build\contextify.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2949): note: see declaration of 'v8::Object::GetRealNamedProperty'
..\src\contextify.cc(209): warning C4996: 'v8::Object::GetRealNamedProperty': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\contextify\build\contextify.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2949): note: see declaration of 'v8::Object::GetRealNamedProperty'
..\src\contextify.cc(210): warning C4996: 'v8::Object::GetRealNamedProperty': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\contextify\build\contextify.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2949): note: see declaration of 'v8::Object::GetRealNamedProperty'
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\Max\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Max\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Max\Code\Forks\most-domless\node_modules\contextify
gyp ERR! node -v v7.2.1
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN install:contextify@0.1.15 contextify@0.1.15 install: `node-gyp rebuild`
npm WARN install:contextify@0.1.15 Exit status 1

> ref@1.0.2 install C:\Users\Max\Code\Forks\most-domless\node_modules\ref
> node-gyp rebuild


C:\Users\Max\Code\Forks\most-domless\node_modules\ref>if not defined npm_config_node_gyp (node "C:\Users\Max\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "
" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  binding.cc
  win_delay_load_hook.cc
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_new.h(34): warning C4996: 'v8::Value::ToInt32': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node
_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(8442): note: see declaration of 'v8::Value::ToInt32' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_new.h(39): warning C4996: 'v8::Value::ToUint32': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\nod
e_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(8436): note: see declaration of 'v8::Value::ToUint32' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(49): warning C4996: 'v8::BooleanObject::New': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\F
orks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(4048): note: see declaration of 'v8::BooleanObject::New' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(166): warning C4996: 'v8::ScriptCompiler::Compile': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\
Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1322): note: see declaration of 'v8::ScriptCompiler::Compile' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(173): warning C4996: 'v8::ScriptCompiler::Compile': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\
Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1322): note: see declaration of 'v8::ScriptCompiler::Compile' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(205): warning C4996: 'v8::String::NewFromOneByte': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\C
ode\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2319): note: see declaration of 'v8::String::NewFromOneByte' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(217): warning C4996: 'v8::String::NewExternal': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code
\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2356): note: see declaration of 'v8::String::NewExternal' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(237): warning C4996: 'v8::ScriptCompiler::CompileUnbound': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Use
rs\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1303): note: see declaration of 'v8::ScriptCompiler::CompileUnbound' (compiling source file ..\src\binding.cc)
c:\users\max\code\forks\most-domless\node_modules\ref\node_modules\nan\nan_implementation_12_inl.h(244): warning C4996: 'v8::ScriptCompiler::CompileUnbound': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Use
rs\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1303): note: see declaration of 'v8::ScriptCompiler::CompileUnbound' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(263): error C2995: 'v8::Local<T> _NanEnsureLocal(v8::Local<T>)': function template has already been defined (compiling source file ..\src\binding.cc) [C:\
Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(256): note: see declaration of '_NanEnsureLocal' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(289): warning C4996: 'v8::Isolate::IdleNotification': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-doml
ess\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(6290): note: see declaration of 'v8::Isolate::IdleNotification' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(473): error C2039: 'GCEpilogueCallback': is not a member of 'v8::Isolate' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(5589): note: see declaration of 'v8::Isolate' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(473): error C2065: 'GCEpilogueCallback': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_module
s\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(474): error C2146: syntax error: missing ')' before identifier 'callback' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(474): error C2143: syntax error: missing ';' before '{' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\b
uild\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(474): error C2447: '{': missing function header (old-style formal list?) (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\n
ode_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(479): error C2039: 'GCEpilogueCallback': is not a member of 'v8::Isolate' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(5589): note: see declaration of 'v8::Isolate' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(479): error C2065: 'GCEpilogueCallback': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_module
s\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(479): error C2146: syntax error: missing ')' before identifier 'callback' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(479): error C2143: syntax error: missing ';' before '{' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\b
uild\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(479): error C2447: '{': missing function header (old-style formal list?) (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\n
ode_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(484): error C2039: 'GCPrologueCallback': is not a member of 'v8::Isolate' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(5589): note: see declaration of 'v8::Isolate' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(484): error C2065: 'GCPrologueCallback': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_module
s\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(485): error C2146: syntax error: missing ')' before identifier 'callback' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(485): error C2143: syntax error: missing ';' before '{' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\b
uild\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(485): error C2447: '{': missing function header (old-style formal list?) (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\n
ode_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(490): error C2039: 'GCPrologueCallback': is not a member of 'v8::Isolate' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(5589): note: see declaration of 'v8::Isolate' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(490): error C2065: 'GCPrologueCallback': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_module
s\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(490): error C2146: syntax error: missing ')' before identifier 'callback' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\
node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(490): error C2143: syntax error: missing ';' before '{' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\b
uild\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(490): error C2447: '{': missing function header (old-style formal list?) (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\n
ode_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(569): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file ..\src\binding.cc) [C:\Users\Max\Co
de\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(569): error C2988: unrecognizable template declaration/definition (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_mod
ules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(569): error C2143: syntax error: missing ',' before '<' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\b
uild\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(661): error C3083: 'smalloc': the symbol to the left of a '::' must be a type (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-doml
ess\node_modules\ref\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(661): error C2039: 'FreeCallback': is not a member of 'node' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\
ref\build\binding.vcxproj]
  C:\Users\Max\.node-gyp\7.2.1\include\node\node_object_wrap.h(8): note: see declaration of 'node' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(661): error C2061: syntax error: identifier 'FreeCallback' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\re
f\build\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(665): error C2065: 'callback': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\buil
d\binding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(665): error C2065: 'hint': undeclared identifier (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\bi
nding.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(672): error C2665: 'node::Buffer::New': none of the 4 overloads could convert all the argument types (compiling source file ..\src\binding.cc) [C:\Users\M
ax\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  C:\Users\Max\.node-gyp\7.2.1\include\node\node_buffer.h(46): note: could be 'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,char *,std::size_t)' (compiling source file ..\src\binding.cc)
  C:\Users\Max\.node-gyp\7.2.1\include\node\node_buffer.h(34): note: or       'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,v8::Local<v8::String>,node::encoding)' (compiling source file ..\src\binding.cc)
  C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(672): note: while trying to match the argument list '(v8::Isolate *, const char *, uint32_t)' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(676): error C2440: 'return': cannot convert from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>' (compiling source file ..\src\binding.cc) [C:\Use
rs\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(676): note: No constructor could take the source type, or constructor overload resolution was ambiguous (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(683): error C2039: 'Use': is not a member of 'node::Buffer' (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\r
ef\build\binding.vcxproj]
  C:\Users\Max\.node-gyp\7.2.1\include\node\node_buffer.h(11): note: see declaration of 'node::Buffer' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(683): error C3861: 'Use': identifier not found (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\bind
ing.vcxproj]
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(710): warning C4996: 'v8::ScriptCompiler::Compile': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domles
s\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1322): note: see declaration of 'v8::ScriptCompiler::Compile' (compiling source file ..\src\binding.cc)
C:\Users\Max\Code\Forks\most-domless\node_modules\ref\node_modules\nan\nan.h(717): warning C4996: 'v8::ScriptCompiler::Compile': was declared deprecated (compiling source file ..\src\binding.cc) [C:\Users\Max\Code\Forks\most-domles
s\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(1322): note: see declaration of 'v8::ScriptCompiler::Compile' (compiling source file ..\src\binding.cc)
..\src\binding.cc(154): error C2661: 'NanNewBufferHandle': no overloaded function takes 4 arguments [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
..\src\binding.cc(271): error C2661: 'NanNewBufferHandle': no overloaded function takes 4 arguments [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
..\src\binding.cc(518): error C2661: 'NanNewBufferHandle': no overloaded function takes 4 arguments [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
..\src\binding.cc(565): error C2661: 'NanNewBufferHandle': no overloaded function takes 4 arguments [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
..\src\binding.cc(642): warning C4996: 'v8::Object::ForceSet': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2706): note: see declaration of 'v8::Object::ForceSet'
..\src\binding.cc(643): warning C4996: 'v8::Object::ForceSet': was declared deprecated [C:\Users\Max\Code\Forks\most-domless\node_modules\ref\build\binding.vcxproj]
  c:\users\max\.node-gyp\7.2.1\include\node\v8.h(2706): note: see declaration of 'v8::Object::ForceSet'
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\Max\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Max\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Max\Code\Forks\most-domless\node_modules\ref
gyp ERR! node -v v7.2.1
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN install:ref@1.0.2 ref@1.0.2 install: `node-gyp rebuild`
npm WARN install:ref@1.0.2 Exit status 1
most@1.2.2 C:\Users\Max\Code\Forks\most-domless
`-- UNMET PEER DEPENDENCY most@^1.1.0

Appears to be caused by an old version of nan, an indirect dependency: joeferner/node-java#250

So perhaps not something that instructions would have prevented, then. I can post a different issue for this if you'd like. Before spending too much time investigating, I assumed there may have been setup steps that I missed, as that's usually been the cause of build failure for a fresh project in my experience.

Tests

Test errors came from the doctest. I figured out how to fix them, but a brief overview of the development setup would have meant less debugging, more proactive development.

@davidchase
Copy link
Collaborator

davidchase commented Mar 4, 2017 •
edited

So the error from \node_modules\contextify i believe is actually from the buster test framework. Since removing that dependency no longer shows that error.

We are currently moving away from buster but those errors should not impede your installation of dependencies

Test errors came from the doctest.

The only thing i saw coming from the doctest were warnings of unhandled promise rejections which is simply because the docs are missing catch() after observing a stream.

This does not reflect any issues with the actual code just an oversight on our part about the examples in the README.md and API.md which should be addressed

I definitely agree that we should have a Contributing Guidelines... so thank you very much for opening the issue. If you have any ideas or thoughts on how they should look please let us know.

Thank again!

@briancavalier
Copy link
Member

briancavalier commented Mar 5, 2017 •
edited

Yeah, it's unfortunate that this is a contextify problem, and that Buster depends on contextify. Alas, it is basically out of our control. It's one reason, like @davidchase said, we've already switched to mocha in @most/core. So, while it's annoying and noisy, everything should still work just fine.

I think we could put together a simple CONTRIBUTING doc quickly, perhaps something like when's or cycle's.

@davidchase
Copy link
Collaborator

I think we could put together a simple CONTRIBUTING doc quickly, perhaps something like when's or cycle's.

those look very nice and simple 👍

@M-Pixel
Copy link
Author

M-Pixel commented Mar 5, 2017

I was thinking in addition to "dos and don'ts", a brief summary of what all the components are, or a list of steps usually taken from start to finish in the course of making a contribution. I see that there are three different test commands run, but I don't know why there are three or what the distinction is. For example, if a test fails after making some change, I don't know if it's because I broke something or because I missed a step and needed to update some secondary test.

Style is largely communicated by the lint configuration and code itself, so I don't think guidelines would need to include that.

@briancavalier briancavalier mentioned this issue Mar 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@briancavalier @davidchase @M-Pixel