Fec (JunOllyLi) #26
Merged
Fec (JunOllyLi) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platformio seems to be enforcing stricter compatibility with unit tests, lets just disable that.
|
cujomalainey, |
|
No worries, I can see bike power needs a bit of TLC, that is fine by me. Any help is appreciated regardless of size. Nothing needs to be done on your end. I can pull in the code here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @JunOllyLi
I noticed you created the FEC and Power meter profiles, would you like to add this to the core library so everyone else can use it? Thanks for the excellent code.