Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct channels do not respect collection level namespace configuration #381

Open
mfen opened this issue Oct 1, 2021 · 0 comments · May be fixed by #382
Open

Direct channels do not respect collection level namespace configuration #381

mfen opened this issue Oct 1, 2021 · 0 comments · May be fixed by #382

Comments

@mfen
Copy link
Contributor

mfen commented Oct 1, 2021

We have a shared service that produces data consumed by multiple, single namespace apps. These consuming apps set their namespace in globalRedisPrefix in settings.json, which applies to both collection and direct channels, i.e. it subscribes to <namespace>::<collection>::<_id>.

At the shared service, we dynamically set the appropriate namespace on mutation per the Fine Tuning example, but found the namespace set here would only apply to the collection level channel, not its corresponding direct channels. i.e. it would send to <collection>::<_id>.

While one workaround would be applying custom config on every collection at the subscribing apps to match the inconsistent dispatch naming, that is much clunkier than the global prefix and would still leave the inconsistent config and naming behaviour. The inconsistent namespacing also makes it harder to do things like subscribe to <namespace>* to observe all activity for a space.

I suggest that a collection level config namespace should match the global prefix behaviour in also applying to the direct channels, resulting in <namespace>::<collection>::<_id>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant