New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rinf contains copied flutter_rust_bridge source code? #218
Comments
Hi @fzyzcjy , thank you for leaving your opinion :) Indeed, Rinf has some code and ideas brought from other projects, as written here: What Rinf is trying to do is to provide new values(such as easier integration, faster setup, reliable workflows) to the ecosystem around Flutter and Rust. That's why we are using the MIT license to contribute to this open-source system. I've tried to make Rinf depend on
So if you look deeper, you will notice quite a lot of modifications, especially inside parts that are related to the web. Also, the communication system between Dart and Rust here is quite simple - we just need to pass a few integers and binary messages between Dart and Rust(Without datetimes, etc). Threrefore, one of the goals here is to slim the engine code.: In short, Rinf couldn't make |
Hi, thank you for the reply. Things like further simplifying the dependency chain, documentation, etc in flutter_rust_bridge has been a part of the plan since the early days. I felt happy to saw Rinf being a high level wrapper of flutter_rust_bridge. By the way, some thoughts about Rinf's approach - passing around messages via Protobuf serialization: Indeed, when I created flutter_rust_bridge, that approach was one of the options I considered, and even implemented and used in production. Quoting my own StackOverflow Q&A-style post in How to call Rust functions in Flutter (Dart) via FFI, but with convenience and safety? - Stack Overflow:
With drawbacks - in addition to abstract reasoning like "FFI-codegen-based is the widely-used approach" - I considered at that time as follows:
Anyway, wish you success! |
Hi, today I found this repository, happy to see the ecosystem of flutter+rust is growing, and curiously looked at the source code (since it does something similar to flutter_rust_bridge). It seems that the engine https://github.com/cunarist/rinf/tree/52fd1f2b06ffd84c528c487aa3a68d53387b40e1/rust_crate/src/engine looks familiar to me - indeed the code in https://github.com/fzyzcjy/flutter_rust_bridge/tree/master/frb_rust/src.
I am (almost) sure you are not deliberately stealing code - since rinf is open source, and you have contributed to FRB :) Therefore, I am quite curious why the code is copy-pasted, instead of using the dependency system? I am afraid copy-pasting will let rinf lose future bugfixs, feature updates, etc, from flutter_rust_bridge.
The text was updated successfully, but these errors were encountered: