Do not share state, by default, for sync or async clients #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #299. Revert the sync client back to not sharing state by default, and make the async client work in the same way.
Also a quick minor fix of the link in the changelog which was taking users to a PR 299, rather than the PR that fixed issue 299.
Note that some of the real Redis tests were failing for me locally but for seemingly unrelated parts of the code so I wasn't sure if that was just something to do with the Redis server on my local machine. Figured I'd see if they fail in CI before spending any time trying to debug them - if they still fail here I'm happy to address them!