Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some messengers can't cope with long links #52

Closed
tkchk opened this issue Aug 12, 2022 · 2 comments · Fixed by #90
Closed

Some messengers can't cope with long links #52

tkchk opened this issue Aug 12, 2022 · 2 comments · Fixed by #90
Labels
enhancement New feature or request

Comments

@tkchk
Copy link

tkchk commented Aug 12, 2022 •
edited
Loading

Screenshot 2022-08-10 at 17 09 48

This is slack, for instance. See those [...] - some users are crazy enough to copy that.
This is more of a messenger issue, but if it can be changed on cryptgeon side, that would be nice.
@cupcakearmy cupcakearmy added the enhancement New feature or request label Aug 15, 2022
@cupcakearmy
Copy link
Owner

This is def. a usability issue and should be fixed, without sacrifying security

@cupcakearmy
Copy link
Owner

I my opinion we have a few options:

  1. Decrease note id size from 256 to 128bit (or 64bit). This does not affect security in any way.
  2. Decrease both note id and encryption key to 128bit. This is still absolutely safe still but if decreasing the note id is enough this might be the way to go.

Also I would put this behind a flag? Maybe something line NOTE_ID_SIZE. Thoughts?

@cupcakearmy cupcakearmy mentioned this issue May 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add note id size option cupcakearmy/cryptgeon
2 participants
@cupcakearmy @tkchk