Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code refactor: theme updates #10

Closed
wants to merge 11 commits into from
Closed

code refactor: theme updates #10

wants to merge 11 commits into from

Conversation

GroovinChip
Copy link
Collaborator

This PR makes a number of changes to the way theming is handled for cupertino_plus:

  • Overhaul CupertinoPlusTheme widget
    • Now takes a single CupertinoPlusThemeData argument
    • Removes the maybeOf function
  • Overhaul CupertinoPlusThemeData class
    • Now uses factory constructors
    • Adds Brightness property
    • Adds debugFillProperties
  • Removes unnecessary icons constructor
  • Adds 100% test coverage for all theme-related classes

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant