Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel=noreferrer? #76

Closed
devd opened this issue Jun 12, 2015 · 3 comments
Closed

rel=noreferrer? #76

devd opened this issue Jun 12, 2015 · 3 comments

Comments

@devd
Copy link
Contributor

devd commented Jun 12, 2015

Happy to submit a PR, but not sure if we want this.

Basically, does it make sense to default to rel=noreferrer on anchors (and I think img also supports it). Obviously, doesn't work on all platforms, but is a reasonable default for untrusted content. Stops referrer leaks and hijacking etc.

@cure53
Copy link
Owner

cure53 commented Jun 13, 2015

No, that would be a hook's job. By adding this as default behaviour we assume too much about how people use DOMPurify.

Happy to accept a PR into the demo folder with a hook though :)

@cure53 cure53 closed this as completed Jun 13, 2015
@devd
Copy link
Contributor Author

devd commented Jun 14, 2015

hmm .. I think there is some value to secure defaults. Are there use cases where you actually do want the referrer on untrusted uncontent?

@cure53
Copy link
Owner

cure53 commented Jun 14, 2015

Our threat model covers XSS and the prevention thereof, not possible privacy issues. We'd have to adjust that first and then move ahead with an implementation.

As mentioned, this would be best in a hook or a separate project using DOMPurify to cover privacy as well. Happy to accept a PR with a hook or support a project addressing privacy as well. The ground work has been done already, should be straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants