Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transcripts and command records #25

Closed
curiousdannii opened this issue Dec 19, 2016 · 4 comments
Closed

Add support for transcripts and command records #25

curiousdannii opened this issue Dec 19, 2016 · 4 comments

Comments

@curiousdannii
Copy link
Owner

With Glk this should not be so difficult.

@curiousdannii
Copy link
Owner Author

Just realised that my handling of the transcript bit is extremely buggy.

@erkyrath Is it safe in general to request special input and char input in GlkOte at the same time? (I know that glkote-term can't, but I can probably fix that, and presumably would need to for Glulx games to be able to use it.) For ZVM though I think I will need to make it issue the input requests sequentially.

@erkyrath
Copy link
Collaborator

If you request specialinput, the rest of the UI is disabled so that the specialinput can act as a modal dialog. So all other input requests are legal, but on hold.

@curiousdannii
Copy link
Owner Author

curiousdannii commented Dec 23, 2016

Gotcha. I will have to ensure that ZVM's specialinput handler doesn't automatically start running VM code again unless it is meant to.

Edit: Actually glkote-term already disables other input when a special request is active! I hadn't fully understood all the code I wrote :P

@curiousdannii
Copy link
Owner Author

I think this is complete and working now. Suggestions or patches to make ZVM match other terps' log formats (especially for char input) are welcome any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants