Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string format instead uf prefix/suffix #15

Closed
micheljung opened this issue Mar 8, 2015 · 2 comments
Closed

Use string format instead uf prefix/suffix #15

micheljung opened this issue Mar 8, 2015 · 2 comments
Assignees
@curioustechizen
Labels
enhancement

Comments

@micheljung
Copy link

Prefix/suffix is not locale friendly, using a String format instead would solve that problem.
@curioustechizen curioustechizen self-assigned this Mar 9, 2015
@curioustechizen
Copy link
Owner

Agreed. I'll explore ways to incorporate this feedback.

What comes to the top of my mind is an overloaded version of the setReferenceTime method that takes a format String and a varargs as parameters. However it might make sense to allow setting the format using an attribute too.

@curioustechizen curioustechizen mentioned this issue Feb 3, 2016
Closed
@curioustechizen
Copy link
Owner

Fixed in v1.4.0. While it is not explicitly using String.format, it does deprecate prefix and suffix in favor of a more general hook to customize the text before display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curioustechizen curioustechizen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curioustechizen @micheljung