Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSdkVersion? #5

Closed
intrications opened this issue Dec 11, 2013 · 4 comments
Closed

minSdkVersion? #5

intrications opened this issue Dec 11, 2013 · 4 comments

Comments

@intrications
Copy link
Contributor

The actual library says android:minSdkVersion="14" but the sample app has android:minSdkVersion="8".

Which is correct?

I'm trying to add Gradle build files and it won't compile without fixing this.

@curioustechizen
Copy link
Owner

Well, when I created the library the intention was to make it ICS and above only - primarily because I did not want to commit to supporting older versions of Android (The library currently does not use any feature that requires minSdkVersion=14)

I'll change the sample app to use minSdkVersion=14 for now.

@marcusforsberg
Copy link

If the library currently does support < 14, any chance that you could change the minSdkVersion to reflect this? This library is crucial for my app but currently the only thing stopping me from supporting < 14. If you don't want to commit to supporting < 14 in the future, you could always put a large notice in the readme. :)

Thanks for your hard work!

@curioustechizen
Copy link
Owner

@marcusforsberg There is a pending PR #14 that sets the minSdk to 11. I hope to merge this in during this week. What minSdk are you targeting?

If this is really urgent, you could clone the repo and set the minSdk yourself as a temporary solution until the official one is published to Maven Central.

Currently the library only requires DateUtils#getRelativeTimeSpanString which is available since API 3. So in theory the minSdk can be set to 3.

@curioustechizen
Copy link
Owner

Set minSdk to 8 with a disclaimer about support for API versions < 11. Fixed in 622747a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants