Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad link to curl-config #65

Closed
jay opened this issue Mar 22, 2020 · 1 comment
Closed

bad link to curl-config #65

jay opened this issue Mar 22, 2020 · 1 comment
Labels

Comments

@jay
Copy link
Member

jay commented Mar 22, 2020

In the LINKING section of libcurl doc there is a bad link to curl-config:

https://curl.haxx.se/libcurl/c/curl-config.html

The correct URL is:

https://curl.haxx.se/libcurl/using/curl-config.html

libcurl/c/Makefile has DOCROOT=$(SRCROOT)/docs passed to roffit to generate the links, and curl-config doc is in the libcurl repo at docs/curl-config.1 so I don't know why it isn't finding the file. It may be a bug in roffit? What is cvssource? I assume an old name that now is the expected location for the git repo?

SRCROOT=$(ROOT)/cvssource
DOCROOT=$(SRCROOT)/docs
MANROOT=$(DOCROOT)/libcurl
OPTMAN=$(DOCROOT)/libcurl/opts
include $(ROOT)/mainparts.mk
include $(ROOT)/setup.mk
MAINPARTS += _menu.html doclinks.t Makefile $(ROOT)/manpage.t $(ROOT)/alert.t
FCPP_OPTS = -DSHOW_ALERT
MAINPARTS_CAPI = $(MAINPARTS) libcurl-related.t
# the files the opts pages depend on
MANPARTS = $(MAINPARTS)
MAN2HTMLBASIC = roffit --bare --mandir=$(MANROOT) --mandir=$(OPTMAN) --mandir=$(DOCROOT)
# postprocess the roffit HTML to add links to curl error codes
MAN2HTML= ( $(MAN2HTMLBASIC) | perl -0x20 -pe '/(CURL(E|M|SHE)_\w*)/; $$err=$$erra=$$1; $$erra =~ s/_//g; s@CURL(E|M|SHE)_\w*@<a href="libcurl-errors.html\#$$erra">$$err</a>@;' )

Attribution:

Bug: https://curl.haxx.se/mail/lib-2020-03/0090.html
Reported-by: Timothe Litt
@jay jay added the bug label Mar 22, 2020
@bagder
Copy link
Member

bagder commented Mar 23, 2020

Yes, cvssource is a link from the web repo to the soure repo (see https://github.com/curl/curl-www/blob/master/bootstrap.sh) and the name was picked back in the old days as you might've guessed.

This bug is indeed roffit related or perhaps because of the way we use roffit on the site. I'll fix it now with a redirect in the apache config.

@bagder bagder closed this as completed in 1e1e22f Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants