Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SHA-256 digest authentication algorithm #1018

Closed
ericmoret opened this issue Sep 16, 2016 · 7 comments
Closed

Support for SHA-256 digest authentication algorithm #1018

ericmoret opened this issue Sep 16, 2016 · 7 comments

Comments

@ericmoret
Copy link

RFC-7616 describes a digest authentication mechanism adding support for two new algorithms, SHA2-256 as mandatory and SHA2-512/256 as a backup. I am interested in using curl with http digest authentication and one of those new algorithms as a replacement for the now defunct standard MD5 hash.

@bagder
Copy link
Member

bagder commented Sep 16, 2016

Thanks a lot for you interest and desire to help us improve curl! Welcome to the project!

There's really no need to file an issue for that (as it isn't really a bug). Just dive in and get working on the feature. If you want some help/assistance during the work, ask on the curl-library mailing list. If you end up with code to offer and want a review for, either post that on the list too or submit a pull requests here on github!

@bagder
Copy link
Member

bagder commented Sep 18, 2016

Feel free to open a pull request when/if you have code. Closing this issue for now.

@bagder bagder closed this as completed Sep 18, 2016
@ciocari
Copy link

ciocari commented Feb 22, 2017

Hi Daniel,
Do you know if there is anyone already working on this?
Thanks!

@bagder
Copy link
Member

bagder commented Feb 22, 2017

I'm not aware of anyone having started at this. Feel free to go ahead!

@aimass
Copy link

aimass commented Dec 6, 2017

Hi, I really need this right now so I am going to fork and try to give minimal support for SHA_256 and SHA_256-sess with auth-int. Do you have to "assign" this formally to me or can I just fork and submit a pull request? also how quickly can this get merged if the patch is sane?

@jay
Copy link
Member

jay commented Dec 6, 2017

Hi, I really need this right now so I am going to fork and try to give minimal support for SHA_256 and SHA_256-sess with auth-int.

First take a look at f20cbac which came from #1934 and is in libcurl 7.57.0, it may have what you're looking for

@jay
Copy link
Member

jay commented Dec 6, 2017

also 2b5b37c

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

5 participants