Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not compile CURL with ngtcp2 v0.17.0 or upper #11448

Closed
owent opened this issue Jul 17, 2023 · 4 comments
Closed

Can not compile CURL with ngtcp2 v0.17.0 or upper #11448

owent opened this issue Jul 17, 2023 · 4 comments
Labels
cmake HTTP/3 h3 or quic related

Comments

@owent
Copy link

owent commented Jul 17, 2023

I did this

Build ngtcp2 v0.17.0, nghttp3 v0.13.0 and nghttp2 v1.55.0 with cmake.

cmake .. -DCMAKE_INSTALL_PREFIX=/opt/tools -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DBUILD_TESTING=OFF -DCURL_ZSTD=ON -DCURL_USE_OPENSSL=ON -DBUILD_SHARED_LIBS=ON -DUSE_NGTCP2=ON -DUSE_NGHTTP2=ON -DOPENSSL_ROOT_DIR=/opt/gcc-13/internal-packages '-DCMAKE_FIND_ROOT_PATH=/opt/gcc-13/internal-packages;/opt/gcc-13;/opt/tools' '-DCMAKE_PREFIX_PATH=/opt/gcc-13/internal-packages;/opt/gcc-13;/opt/tools'

I expected the following

I expected build success. but got

CMake Error at /opt/cmake/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find NGTCP2 (missing: OpenSSL) (found version "0.17.90")
Call Stack (most recent call first):
  /opt/cmake/share/cmake-3.26/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  CMake/FindNGTCP2.cmake:102 (find_package_handle_standard_args)
  CMakeLists.txt:605 (find_package)

curl/libcurl version

8.1.2

operating system

CentOS 8

Additional

According to the release note of ngtcp2 ( ngtcp2/ngtcp2#777 ), the openssl suffix is renamed into quictls now.There is a PR #11428 which support the new name but I don't know why it's closed now. I think it's better to support bothen the new and the old names.

@bagder bagder added cmake HTTP/3 h3 or quic related labels Jul 19, 2023
@bagder
Copy link
Member

bagder commented Jul 19, 2023

There is a PR #11428 which support the new name but I don't know why it's closed now

It is merged. You should probably update and use newer curl code and see if the problem is fixed?

@owent
Copy link
Author

owent commented Jul 19, 2023

There is a PR #11428 which support the new name but I don't know why it's closed now

It is merged. You should probably update and use newer curl code and see if the problem is fixed?

Thanks, don't we support ngtcp2 v0.16.0 or before? I find the old ngtcp2_crypto_openssl is removed completely.

@bagder
Copy link
Member

bagder commented Jul 19, 2023

We only maintain support for the latest ngtcp2 version at all times (until they ship their first non-beta). Currently this means 0.17.0.

@owent
Copy link
Author

owent commented Jul 19, 2023

Thanks.

@owent owent closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake HTTP/3 h3 or quic related
Development

No branches or pull requests

2 participants