Add missing DarwinSSL block to curl_config.cmake #1270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Sukender, @jzakrzewski and @dcreager to be potential reviewers. |
|
can't we just roll that in, why separate? |
|
Possible, yes. But I cannot write commits to the PR and did not yet hear from the author. I separated it, because other TLS implementations like PolarSSL and mbedTLS are already in the file, even if those are not yet supported by the cmake build. So this adds some symmetry. |
|
I'd rather we give the OP in that PR a chance to improve it, so I'm closing in favor of that. Go to review and then Request Changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparing step for #1228