Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_HEADERFUNCTION man page: #4758

Closed
gevaerts opened this issue Dec 25, 2019 · 2 comments
Closed

CURLOPT_HEADERFUNCTION man page: #4758

gevaerts opened this issue Dec 25, 2019 · 2 comments
Labels

Comments

@gevaerts
Copy link
Contributor

@gevaerts gevaerts commented Dec 25, 2019

the man page for CURLOPT_WRITEFUNCTION mentions that "the size of that data is nmemb; size is always 1", the man page for CURLOPT_HEADERFUNCTION mentions no constraints about size. I think it would be a good idea to clarify if this will also always be 1, or, if not, to explicitly mention that size!=1 might be the case.

@jay jay added the documentation label Dec 26, 2019
@jay
Copy link
Member

@jay jay commented Dec 26, 2019

Why do we need to be explicit about it? I like that there's some wiggle room, also we'd have to go back to all previous versions to find out how it handles that to make sure it's correct.

@jay jay closed this in 97934a2 Dec 26, 2019
@jay
Copy link
Member

@jay jay commented Dec 26, 2019

After reading #2787 I changed my mind. Also, I went all the way back (using git gui blame and repeatedly blamed parent) and it's always been 1. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.