Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10535 sdk python test callback race #55

Closed

Conversation

jrandall
Copy link
Contributor

@jrandall jrandall commented Nov 15, 2016

fixes 10535

@jrandall
Copy link
Contributor Author

Change 10.0s to a constant

@tomclegg
Copy link
Member

I changed the notification mechanism here from threading.Condition() to threading.Event() in a983bbe, which (according to my reasoning, and a few trials) fixes the race and eliminates the need for sleep(). Still added the 10-second timeouts proposed here though, so if the code breaks then the tests fail instead of hanging. @jrandall if a983bbe (in master) works for you too, I think we can close this PR. Either way, thanks for pinning this down!

@tfmorris
Copy link

tfmorris commented Jun 4, 2018

@jrandall I'm assuming that this fixed things, so closing the PR, but if not, please feel free to reopen.

@tfmorris tfmorris closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants