Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSR-213] Support Code Coverage #174

Merged
merged 11 commits into from
Aug 25, 2023
Merged

[CSR-213] Support Code Coverage #174

merged 11 commits into from
Aug 25, 2023

Conversation

vCaisim
Copy link
Contributor

@vCaisim vCaisim commented Aug 14, 2023

Changes:

  • added --experimental-coverage-recording option which will upload code coverage result created by @cypress/code-coverage for each instance
  • added the frontend app to the examples to show the option usage

depends on https://github.com/currents-dev/currents/pull/419

@vCaisim vCaisim requested a review from agoldis August 14, 2023 14:22
@vCaisim vCaisim changed the title Code Coverage [CSR-213] Code Coverage Aug 14, 2023
@notion-workspace
Copy link

Code Coverage

Copy link
Contributor

@agoldis agoldis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @vCaisim! Would you mind please renaming examples/frontend to example/coverage

.addOption(
new Option(
`--experimental-coverage-recording [bool]`,
`Whether to record coverage results. Use "coverageFile" Cypress environment variable for a custom coverage file, default is "./.nyc_output/out.json"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use or Uses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use or Uses?

Formulation was changed

@agoldis agoldis changed the title [CSR-213] Code Coverage [CSR-213] Support Code Coverage Aug 25, 2023
@agoldis agoldis merged commit ddc6b1f into main Aug 25, 2023
14 checks passed
@agoldis agoldis deleted the feat/coverage branch August 25, 2023 21:06
agoldis added a commit that referenced this pull request Aug 25, 2023
* wip

* feat: handle coverage

* fix: use cypress-cloud for test script in frontend app

* feat: add experimentalCoverageRecording plugin option

* fix: change the script that tests frontend example app

* feat: add coverageEnabled flag to CreateRunPayload

* chore: rename from examples/frontend to examples/coverage

* chore: wip

* chore: ..

---------

Co-authored-by: Andrew Goldis <agoldis@gmail.com>
agoldis added a commit that referenced this pull request Aug 25, 2023
* wip

* feat: handle coverage

* fix: use cypress-cloud for test script in frontend app

* feat: add experimentalCoverageRecording plugin option

* fix: change the script that tests frontend example app

* feat: add coverageEnabled flag to CreateRunPayload

* chore: rename from examples/frontend to examples/coverage

* chore: wip

* chore: ..

---------

Co-authored-by: Andrew Goldis <agoldis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants