Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Structure support for EDN files #2706

Closed
markaddleman opened this issue Jun 3, 2022 · 9 comments
Closed

File Structure support for EDN files #2706

markaddleman opened this issue Jun 3, 2022 · 9 comments
Labels
new Marks issues describing new features released Marks issues which have had the fixes released in a stable build released-eap Marks issues which have had the fixes released in an EAP build
Milestone

Comments

@markaddleman
Copy link

In reference to https://clojurians.slack.com/archives/C0744GXCJ/p1654265565732809

My specific use case is deps.edn . I'd like to open the file structure browser, type in a few characters of a dependency to jump to that point in the file. I believe IntelliJ's has file structure support for JSON files and I imagine EDN support would be very similar.

Screenshot 2022-06-03 9 43 22 AM

@onetom
Copy link

onetom commented Jun 7, 2022

Interesting idea... I've tried jet -p -o json < deps.edn > deps.json and here is how it would look like, with the source popup (Opt-Space) on its right, as a content preview for the selected subtree:
image

@cursive-ide cursive-ide added this to the 1.13.1 milestone Sep 24, 2023
@cursive-ide cursive-ide modified the milestones: 1.13.1, 1.13.1-eap5 Sep 25, 2023
@cursive-ide cursive-ide added the new Marks issues describing new features label Sep 25, 2023
@serioga
Copy link

serioga commented Sep 25, 2023

Hm, why only in EDN files?

@cursive-ide
Copy link
Owner

@serioga Because there's already structure support in Clojure files. I've only added breadcrumb support for EDN files for the moment since it's easier, but I'll add it for Clojure shortly.

Screenshot 2023-09-25 at 22 36 26

@serioga
Copy link

serioga commented Sep 25, 2023

Well, it would be totally great to have structure support integrated with Navigation Bar as well, like in other languages.

2023-09-25_121500

@serioga
Copy link

serioga commented Sep 25, 2023

Also now I see an empty bar in clj files, in place of breadcrumbs...

@cursive-ide
Copy link
Owner

Yes, my plan is to integrate the nav bar support in the next EAP. Once that is in, I will probably disable the breadcrumb support by default, but you'll be able to switch it on in the settings. This is how Java and Kotlin currently work.

The empty bar is unfortunate, but that's just because I haven't implemented the breadcrumbs for CLJ yet, only for EDN. I can't turn it on for one and off for the other, because IntelliJ considers them the same language. Once I have both implemented that will show the breadcrumbs (assuming you have them enabled).

@cursive-ide
Copy link
Owner

The next EAP has full support for breadcrumbs in Clojure (no empty bar), and also has nav bar support for Clojure code.

@cursive-ide
Copy link
Owner

Fix released in 1.13.1-eap5 on 2023-09-25.

@cursive-ide cursive-ide added the released-eap Marks issues which have had the fixes released in an EAP build label Oct 30, 2023
@cursive-ide
Copy link
Owner

Fix released in 1.13.1 on 2023-12-07.

@cursive-ide cursive-ide added the released Marks issues which have had the fixes released in a stable build label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new Marks issues describing new features released Marks issues which have had the fixes released in a stable build released-eap Marks issues which have had the fixes released in an EAP build
Projects
None yet
Development

No branches or pull requests

4 participants