Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Run Test under Caret in REPL" no longer re-loads modified namespaces #463

Closed
voj opened this issue Aug 17, 2014 · 6 comments
Closed

"Run Test under Caret in REPL" no longer re-loads modified namespaces #463

voj opened this issue Aug 17, 2014 · 6 comments
Milestone

Comments

@voj
Copy link

voj commented Aug 17, 2014

The action "Run Test under Caret in REPL" no longer re-loads the namespace for the test or any other dependencies that have been modified since the last run.

Now I always have to call "Load file in REPL" first before running a test after I have modified the file (or any file the test depends on).

Cursive 0.1.31, IntelliJ 13.1.3. Ultimate

@cursive-ide cursive-ide added this to the 0.1.32 milestone Aug 17, 2014
@cursive-ide
Copy link
Owner

That's unfortunate - I'll take a look.

@cursive-ide
Copy link
Owner

Hmm, I can't reproduce this - I'm seeing both the test namespace and a modified dependency being loaded. Are you seeing any errors coming out in the REPL?

@cursive-ide
Copy link
Owner

Actually, could you also check if you're seeing errors in your log?

@voj
Copy link
Author

voj commented Aug 17, 2014

It looks as though this only happens for projects that depend on good old korma. I have been able to run tests just fine in other projects.

There's nothing in the log, but there's a bubble displayed with the message:
Dependency cycle: clj:korma.sql.engine -> clj:korma.sql.engine

Loading the namespaces in question with the "Load file in REPL" works fine and does not display the bubble. The problem only occurs when running tests in not previously loaded namespaces or modified namespaces.

@cursive-ide
Copy link
Owner

Ahhh... this is actually a Korma bug, see: #189 and korma/Korma#194 which I filed some time ago. This is marked as fixed, is it possible for you to upgrade your Korma version? IIRC I made a hack so that Cursive wouldn't barf on this problem, but I can't remember the details - I'll dig in the code a bit.

@cursive-ide
Copy link
Owner

This was indeed due to that Korma bug. I've re-introduced the hack from the previous code for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants