Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit iteration scope facets for "funk" and "funk name" #2375

Open
pokey opened this issue May 31, 2024 · 1 comment
Open

Revisit iteration scope facets for "funk" and "funk name" #2375

pokey opened this issue May 31, 2024 · 1 comment
Labels
code quality Improvements to code quality

Comments

@pokey
Copy link
Member

pokey commented May 31, 2024

Yeah so the issue is that we don't necessarily want the iteration scope for functions to always include blocks. For example, that's not what we do in typescript. I added this as a catch-all so that I could include blocks for css. Might be worth discussing?

Originally posted by @pokey in #2339 (comment)
@pokey pokey added to discuss Plan to discuss at meet-up code quality Improvements to code quality labels May 31, 2024
@pokey pokey changed the title Revisit facets for funk and funk name iteration scopes Revisit iteration scope facets for "funk and funk name Jun 1, 2024
@pokey pokey changed the title Revisit iteration scope facets for "funk and funk name Revisit iteration scope facets for "funk" and "funk name" Jun 1, 2024
@pokey
Copy link
Member Author

pokey commented Jun 2, 2024

update from meet-up:

  • Let's leave it for now
  • In the future, one way forward is to support language-specific facets and then add namedFunction.iteration.block as a css-specific facet

@pokey pokey removed the to discuss Plan to discuss at meet-up label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvements to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pokey