-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate in-app module from gist to CIO #221
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
=============================================
- Coverage 62.86% 49.65% -13.21%
- Complexity 234 237 +3
=============================================
Files 94 108 +14
Lines 2149 2775 +626
Branches 282 362 +80
=============================================
+ Hits 1351 1378 +27
- Misses 690 1282 +592
- Partials 108 115 +7
|
Build available to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. But since this isn't a breaking change and our wrapper SDKs will fetch these changes automatically at new build, have you tested this with them? Is there anything that could affect customers using them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To speedup my review, I am assuming that all code inside of the messaginginapp
module is a direct copy/paste from the Gist SDK. So, code that has already been approved. Is this correct?
I have reviewed all other code in this PR. And if the assumption is correct, I approve.
I do see only 1 lint error for |
@levibostian mostly yes, but like for the lint issue you provided above, had to readjust some code to not use the API 24 rather lower API version. |
### [3.6.1](3.6.0...3.6.1) (2023-07-12) ### Bug Fixes * migrate in-app module from gist to CIO ([#221](#221)) ([d6fda6d](d6fda6d))
closes: https://github.com/customerio/issues/issues/10295