Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate in-app module from gist to CIO #221

Merged
merged 14 commits into from
Jul 12, 2023
Merged

Conversation

Shahroz16
Copy link
Contributor

@Shahroz16 Shahroz16 commented Jun 19, 2023

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: shahroz/merge-gist (1689173220)
  • kotlin_compose: shahroz/merge-gist (1689173209)

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #221 (56a55dd) into main (1e289d7) will decrease coverage by 13.21%.
The diff coverage is 4.31%.

@@              Coverage Diff              @@
##               main     #221       +/-   ##
=============================================
- Coverage     62.86%   49.65%   -13.21%     
- Complexity      234      237        +3     
=============================================
  Files            94      108       +14     
  Lines          2149     2775      +626     
  Branches        282      362       +80     
=============================================
+ Hits           1351     1378       +27     
- Misses          690     1282      +592     
- Partials        108      115        +7     
Impacted Files Coverage Δ
...io/customer/messaginginapp/gist/GistEnvironment.kt 0.00% <0.00%> (ø)
...tomer/messaginginapp/gist/data/NetworkUtilities.kt 0.00% <0.00%> (ø)
...stomer/messaginginapp/gist/data/listeners/Queue.kt 0.00% <0.00%> (ø)
...ustomer/messaginginapp/gist/data/model/LogEvent.kt 0.00% <0.00%> (ø)
...p/gist/data/model/engine/EngineWebConfiguration.kt 0.00% <0.00%> (ø)
...ginginapp/gist/data/repository/GistQueueService.kt 0.00% <0.00%> (ø)
...saginginapp/gist/presentation/GistModalActivity.kt 0.00% <0.00%> (ø)
...ssaginginapp/gist/presentation/GistModalManager.kt 0.00% <0.00%> (ø)
...stomer/messaginginapp/gist/presentation/GistSdk.kt 0.00% <0.00%> (ø)
...tomer/messaginginapp/gist/presentation/GistView.kt 0.00% <0.00%> (ø)
... and 7 more

@github-actions
Copy link

Build available to test
Version: shahroz-merge-gist-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@Shahroz16 Shahroz16 requested a review from a team June 19, 2023 11:52
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. But since this isn't a breaking change and our wrapper SDKs will fetch these changes automatically at new build, have you tested this with them? Is there anything that could affect customers using them?

messaginginapp/build.gradle Show resolved Hide resolved
Copy link
Member

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To speedup my review, I am assuming that all code inside of the messaginginapp module is a direct copy/paste from the Gist SDK. So, code that has already been approved. Is this correct?

I have reviewed all other code in this PR. And if the assumption is correct, I approve.

@levibostian
Copy link
Member

I do see only 1 lint error for messaginginapp. I am going to assume that this lint error will be fixed before merging?

@Shahroz16
Copy link
Contributor Author

To speedup my review, I am assuming that all code inside of the messaginginapp module is a direct copy/paste from the Gist SDK. So, code that has already been approved. Is this correct?

I have reviewed all other code in this PR. And if the assumption is correct, I approve.

@levibostian mostly yes, but like for the lint issue you provided above, had to readjust some code to not use the API 24 rather lower API version.

@Shahroz16 Shahroz16 merged commit d6fda6d into main Jul 12, 2023
30 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/merge-gist branch July 12, 2023 15:27
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
### [3.6.1](3.6.0...3.6.1) (2023-07-12)

### Bug Fixes

* migrate in-app module from gist to CIO ([#221](#221)) ([d6fda6d](d6fda6d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants