-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate classes crash on wrappers #239
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=============================================
- Coverage 49.65% 16.39% -33.27%
+ Complexity 237 59 -178
=============================================
Files 108 40 -68
Lines 2775 1269 -1506
Branches 362 185 -177
=============================================
- Hits 1378 208 -1170
+ Misses 1282 1033 -249
+ Partials 115 28 -87 |
Build available to test |
### [3.6.2](3.6.1...3.6.2) (2023-07-13) ### Bug Fixes * duplicate classes crash on wrappers ([#239](#239)) ([ead2175](ead2175))
While randomly testing react native sample app, which had a lower Kotlin version we bumped into an issue.
It was caused because
lifecycle-runtime-ktx:2.6.1
is being compiled by Kotlin 1.8.10 while, our SDK is being compiled by 1.7.21. So our duplicate kotlin versions were being sent.So until, we upgrade the kotlin version to 1.8.10, we have to make sure all the dependencies being used are also compiled by our current kotlin version, 1.7.21.