Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent empty identifier and device token #240

Merged
merged 4 commits into from Jul 14, 2023
Merged

fix: prevent empty identifier and device token #240

merged 4 commits into from Jul 14, 2023

Conversation

Shahroz16
Copy link
Contributor

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

@Shahroz16 Shahroz16 requested a review from a team July 14, 2023 11:10
@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

  • java_layout: shahroz/fix-empty-identifier (1689340046)
  • kotlin_compose: shahroz/fix-empty-identifier (1689340043)

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited

Codecov Report

Merging #240 (91cb3ff) into main (ead2175) will decrease coverage by 34.54%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #240       +/-   ##
=============================================
- Coverage     49.65%   15.12%   -34.54%     
+ Complexity      237       32      -205     
=============================================
  Files           108       22       -86     
  Lines          2775      800     -1975     
  Branches        362       88      -274     
=============================================
- Hits           1378      121     -1257     
+ Misses         1282      663      -619     
+ Partials        115       16       -99

see 86 files with indirect coverage changes

@github-actions
Copy link

Build available to test
Version: shahroz-fix-empty-identifier-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

mrehan27
mrehan27 reviewed Jul 14, 2023
View reviewed changes
sdk/src/sharedTest/java/io/customer/sdk/repository/ProfileRepositoryTest.kt Outdated
@@ -67,6 +67,29 @@ class ProfileRepositoryTest : BaseTest() {
verifyNoMoreInteractions(backgroundQueueMock)
}

@Test
fun identify_givenEmptyIdentifier_expectNoIdentifyBackgroundQueue() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add test to expect no updates in profile for empty identifier when it is already identified?

mrehan27
mrehan27 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@Shahroz16 Shahroz16 merged commit e9b5d0c into main Jul 14, 2023
26 of 30 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-empty-identifier branch July 14, 2023 13:11
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
@semantic-release-bot
chore: prepare for 3.6.3
84cdcbc 
### [3.6.3](3.6.2...3.6.3) (2023-07-14)

### Bug Fixes

* prevent empty identifier and device token ([#240](#240)) ([e9b5d0c](e9b5d0c))
@ami-aman ami-aman mentioned this pull request Jul 14, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrehan27 mrehan27 mrehan27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shahroz16 @mrehan27