New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: in-app messaging proguard rules missing #241
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
=============================================
+ Coverage 20.20% 49.76% +29.55%
- Complexity 27 237 +210
=============================================
Files 19 108 +89
Lines 480 2781 +2301
Branches 99 364 +265
=============================================
+ Hits 97 1384 +1287
- Misses 371 1282 +911
- Partials 12 115 +103 |
Build available to test |
### [3.6.4](3.6.3...3.6.4) (2023-07-21) ### Bug Fixes * in-app messaging proguard rules missing ([#241](#241)) ([c494bb0](c494bb0))
Gist proguard settings didn't get copied over when in-app module code was migrated from Gist SDK into the CIO SDK. This PR adds those proguard rules back. Also enables proguard on sample apps so we can better test Release builds like customers are.
Fixes: https://github.com/customerio/opsbugs/issues/3627