Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last used format for device #287

Merged
merged 3 commits into from Mar 21, 2024
Merged

fix: last used format for device #287

merged 3 commits into from Mar 21, 2024

Conversation

Shahroz16
Copy link
Contributor

closes: https://linear.app/customerio/issue/MBL-170/incorrect-last-used-value-being-sent-from-android-sdk

Device payload was using lastUsed instead of last_used while adding a device/device attributes which BE doesn't accept.

@Shahroz16 Shahroz16 changed the title fix: last_used format for device fix: last used format for device Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: shahroz/fix-last-used (1711037112)
  • kotlin_compose: shahroz/fix-last-used (1711037117)

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.43%. Comparing base (0306618) to head (f887b79).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #287      +/-   ##
============================================
+ Coverage     54.35%   54.43%   +0.07%     
- Complexity      278      282       +4     
============================================
  Files           109      109              
  Lines          2535     2535              
  Branches        355      355              
============================================
+ Hits           1378     1380       +2     
  Misses         1033     1033              
+ Partials        124      122       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Build available to test
Version: shahroz-fix-last-used-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@Shahroz16 Shahroz16 requested a review from a team March 21, 2024 14:04
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

sdk/src/main/java/io/customer/sdk/data/request/Device.kt Outdated Show resolved Hide resolved
@Shahroz16 Shahroz16 merged commit 726667b into main Mar 21, 2024
28 of 30 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-last-used branch March 21, 2024 16:15
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
## [3.9.1](3.9.0...3.9.1) (2024-03-21)

### Bug Fixes

* last used format for device ([#287](#287)) ([726667b](726667b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants