feat: fixed issues with adding file to target #10

xtreem88 · 2022-11-26T13:41:05Z

https://github.com/customerio/issues/issues/8669
This PR fixes the issue with xcode not recognizing PushNotification.swift and requiring an extra step of adding the file after prebuild

src/ios/withNotificationsXcodeProject.ts

…n into add-file-to-ios-target

ami-oss-ci · 2022-12-01T07:55:12Z

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.
fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.
docs: - This pull request is making documentation changes, only.
refactor: - A change was made that doesn't fix a bug or add a feature.
test: - Adds missing tests or fixes broken tests.
style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)
perf: - Changes improve performance of the code.
build: - Changes to the build system (maven, npm, gulp, etc)
ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)
chore: - Other changes to project that don't modify source code or test files.
revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

levibostian · 2022-12-01T15:41:40Z

@xtreem88 Why is this PR a breaking change?

Since we are still just in alpha, I don't see any issues with introducing breaking changes to the code without any migration steps taken. However, I am still curious how this is a breaking change?

xtreem88 · 2022-12-02T11:48:08Z

@xtreem88 Why is this PR a breaking change?

Since we are still just in alpha, I don't see any issues with introducing breaking changes to the code without any migration steps taken. However, I am still curious how this is a breaking change?

Thanks for pointing this out. This was a mistake... I was testing the integration with pr_lint job, and I forgot to change this. I'll do that now.

xtreem88 · 2022-12-02T11:52:35Z

@ami-aman @levibostian I am going to clean up this PR soon. I have been testing the changes with different Expo managed projects, and it seems to hold up well. After this, I would need another round of reviews.

src/helpers/constants/ios.ts

src/ios/withNotificationsXcodeProject.ts

levibostian

Blocking PR because the way we install versions of RN and iOS SDKs are not consistent. My PR comments address this.

package.json

src/helpers/constants/ios.ts

## [1.0.0-alpha.6](1.0.0-alpha.5...1.0.0-alpha.6) (2022-12-30) ### ⚠ BREAKING CHANGES * changed googleServicesFilePath to googleServicesFile (#16) ### Features * fixed issues with adding file to target ([#10](#10)) ([0674c66](0674c66)) * rich push environment variable setup ([#23](#23)) ([8d83c95](8d83c95)) * user agent for expo ([#8](#8)) ([19e78b1](19e78b1)) ### Code Refactoring * changed googleServicesFilePath to googleServicesFile ([#16](#16)) ([26be4db](26be4db))

ami-ci · 2022-12-30T14:43:31Z

🎉 This PR is included in version 1.0.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## 1.0.0-beta.1 (2022-12-30) ### ⚠ BREAKING CHANGES * changed googleServicesFilePath to googleServicesFile (#16) ### Features * added ability to set use_frameworks to static ([#9](#9)) ([05d7012](05d7012)) * fixed issues with adding file to target ([#10](#10)) ([0674c66](0674c66)) * rich push environment variable setup ([#23](#23)) ([8d83c95](8d83c95)) * user agent for expo ([#8](#8)) ([19e78b1](19e78b1)) ### Bug Fixes * fixed info.plist formatting issue ([#18](#18)) ([d701794](d701794)) * update .releaserc.json ([#21](#21)) ([8c751cf](8c751cf)) * updated package version ([#19](#19)) ([ab30383](ab30383)) ### Code Refactoring * changed googleServicesFilePath to googleServicesFile ([#16](#16)) ([26be4db](26be4db))

ami-ci · 2022-12-30T17:50:52Z

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

xtreem88 added 2 commits November 26, 2022 17:07

fixed issues with adding file to target

407f77c

cleanup

9140b9e

xtreem88 requested review from ami-aman, levibostian, mrehan27 and Shahroz16 November 26, 2022 14:38

xtreem88 changed the title ~~feat: fixed issues with adding file to target~~ feat!: fixed issues with adding file to target Nov 26, 2022

xtreem88 changed the title ~~feat!: fixed issues with adding file to target~~ feat!: Fixed issues with adding file to target Nov 26, 2022

xtreem88 changed the title ~~feat!: Fixed issues with adding file to target~~ feat!: fixed issues with adding file to target Nov 26, 2022

levibostian reviewed Nov 28, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Show resolved Hide resolved

src/ios/withNotificationsXcodeProject.ts Outdated Show resolved Hide resolved

src/ios/withNotificationsXcodeProject.ts Outdated Show resolved Hide resolved

levibostian reviewed Nov 28, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Show resolved Hide resolved

xtreem88 added 3 commits November 30, 2022 09:59

changed pushnotifications target name

f0a6793

Merge branch 'develop' of github.com:customerio/customerio-expo-plugi…

aabe994

…n into add-file-to-ios-target

restore release file

e4f6d30

xtreem88 mentioned this pull request Dec 1, 2022

feat: update for iOS SDK v2 #15

Closed

xtreem88 changed the title ~~feat!: fixed issues with adding file to target~~ feat: fixed issues with adding file to target Dec 2, 2022

xtreem88 added 2 commits December 2, 2022 16:31

Renamed PushService and cleaned up docs

707dd40

updated SDK for testing purpose

91add06

xtreem88 commented Dec 2, 2022

View reviewed changes

src/helpers/constants/ios.ts Outdated Show resolved Hide resolved

xtreem88 added 3 commits December 2, 2022 18:51

added comments

bf37d2c

added version constraint

3cce6b1

npm sync

6a728a9

ami-aman reviewed Dec 6, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Show resolved Hide resolved

ami-aman reviewed Dec 6, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Show resolved Hide resolved

ami-aman reviewed Dec 6, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Outdated Show resolved Hide resolved

doc update

7711569

Shahroz16 reviewed Dec 6, 2022

View reviewed changes

src/ios/withNotificationsXcodeProject.ts Show resolved Hide resolved

levibostian requested changes Dec 6, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/helpers/constants/ios.ts Outdated Show resolved Hide resolved

src/helpers/constants/ios.ts Outdated Show resolved Hide resolved

xtreem88 added 5 commits December 6, 2022 21:37

changed googleServicesFile option

7a57b25

revert

8adb9c4

pr fix

5a7814d

sync

314fac6

refactor

046f357

levibostian approved these changes Dec 7, 2022

View reviewed changes

xtreem88 merged commit 0674c66 into develop Dec 10, 2022

xtreem88 deleted the add-file-to-ios-target branch December 10, 2022 08:03

ami-ci added the released on @alpha label Dec 30, 2022

ami-ci added the released on @beta label Dec 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fixed issues with adding file to target #10

feat: fixed issues with adding file to target #10

xtreem88 commented Nov 26, 2022 •

edited

ami-oss-ci commented Dec 1, 2022 •

edited

Examples:

levibostian commented Dec 1, 2022

xtreem88 commented Dec 2, 2022

xtreem88 commented Dec 2, 2022

levibostian left a comment

ami-ci commented Dec 30, 2022

ami-ci commented Dec 30, 2022

feat: fixed issues with adding file to target #10

feat: fixed issues with adding file to target #10

Conversation

xtreem88 commented Nov 26, 2022 • edited

ami-oss-ci commented Dec 1, 2022 • edited

Examples:

levibostian commented Dec 1, 2022

xtreem88 commented Dec 2, 2022

xtreem88 commented Dec 2, 2022

levibostian left a comment

Choose a reason for hiding this comment

ami-ci commented Dec 30, 2022

ami-ci commented Dec 30, 2022

xtreem88 commented Nov 26, 2022 •

edited

ami-oss-ci commented Dec 1, 2022 •

edited