Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flexible notification request handling #40

Merged
merged 14 commits into from Feb 25, 2023

Conversation

xtreem88
Copy link
Collaborator

@xtreem88 xtreem88 commented Feb 21, 2023

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@xtreem88 xtreem88 changed the base branch from develop to beta February 21, 2023 18:02
@xtreem88 xtreem88 changed the title Flexible notification request fix: flexible notification request Feb 24, 2023
@xtreem88 xtreem88 changed the title fix: flexible notification request feat: flexible notification request handling Feb 24, 2023
@xtreem88 xtreem88 requested a review from a team February 24, 2023 07:06
@xtreem88 xtreem88 marked this pull request as ready for review February 24, 2023 11:05
Copy link

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, if my assumptions are correct, Android part seems good to me 👍🏻

@xtreem88
Copy link
Collaborator Author

Just one question, if my assumptions are correct, Android part seems good to me 👍🏻

Correct!

@ami-aman
Copy link
Contributor

I tested the branch on a sample app and found that on disableNotificationRegistration: true, the plugin did not add registerPushNotification method call in AppDelegate's didFinishLaunchingWithOptions but CIOAppPushNotificationsHandler class in PushService.swift file still had registerPushNotification method declaration.

This was tested using prebuild & prebuild --clean and both had same results in PushService.swift

@xtreem88
Copy link
Collaborator Author

I tested the branch on a sample app and found that on disableNotificationRegistration: true, the plugin did not add registerPushNotification method call in AppDelegate's didFinishLaunchingWithOptions but CIOAppPushNotificationsHandler class in PushService.swift file still had registerPushNotification method declaration.

This was tested using prebuild & prebuild --clean and both had same results in PushService.swift

Fixed!

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

Hey, there @xtreem88 👋🤖. I'm a bot here to help you.

⚠️ Pull requests into the branch beta typically only allows changes with the types: fix. From the pull request title, the type of change this pull request is trying to complete is: feat. ⚠️

This pull request might still be allowed to be merged. However, you might want to consider make this pull request merge into a different branch other then beta.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

README.md Show resolved Hide resolved
@xtreem88 xtreem88 merged commit 447a7c2 into beta Feb 25, 2023
@xtreem88 xtreem88 deleted the flexible-notification-request branch February 25, 2023 09:48
github-actions bot pushed a commit that referenced this pull request Feb 27, 2023
## [1.0.0-beta.4](1.0.0-beta.3...1.0.0-beta.4) (2023-02-27)

### Features

* flexible notification request handling ([#40](#40)) ([447a7c2](447a7c2))
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants