Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation improvement for use_frameworks #7

Closed
MatiasLjubica opened this issue Nov 15, 2022 · 3 comments
Closed

Installation improvement for use_frameworks #7

MatiasLjubica opened this issue Nov 15, 2022 · 3 comments

Comments

@MatiasLjubica
Copy link

MatiasLjubica commented Nov 15, 2022

Hi ! I try to use this plugin to my Expo projet but I having some trouble to install pod dependency because my project also use Analytics and it's require to use the use_framework! tag but it's break the build with this error:

- Runner (true) and NotificationService (false) do not both set use_frameworks!.

So i add this:

target 'NotificationService' do
  use_frameworks!
  pod 'CustomerIO/MessagingPushAPN', '~> 1.2.0-alpha.3'
end

but it fail because he need to be static, so i use this:

target 'NotificationService' do
  use_frameworks! :linkage => :static
  pod 'CustomerIO/MessagingPushAPN', '~> 1.2.0-alpha.3'
end

and it work !

Can you add an option into the plugin to add this line if the project use use_framework ?

Thank you

@xtreem88 xtreem88 self-assigned this Nov 16, 2022
@ami-aman
Copy link
Contributor

Hi @MatiasLjubica

I appreciate you asking this feature request in our config plugin. Just to make sure we understand it right, would it be justified to say that the request is to make the plugin configurable such that even static libraries could be linked in iOS using :linkage => :static ? Feel free to correct me if I am wrong !

@MatiasLjubica
Copy link
Author

Hi @ami-aman
Yes is the request to be clear we can have some properties in app.config like:

    [
      'customerio-expo-plugin',
      {
        android: {
          googleServicesFilePath: 'PATH',
        },
        ios: {
          useFrameworks: 'static', // can be 'none' | 'static' | 'dynamic'
          pushNotification: {
            useRichPush: true,
          },
        },
      },
    ]

It will help for project that use some other packages. I think it can be reproduce with a blank Expo project with @react-native-firebase/analytics and try to install the plugin.

They have the same issue on OneSignal Flutter SDK that i found how to resolve it.

@xtreem88
Copy link
Collaborator

xtreem88 commented Dec 6, 2022

This feature has been added and released. See #9

@xtreem88 xtreem88 closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants