Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user agent for expo #8

Merged
merged 23 commits into from Dec 1, 2022
Merged

feat: user agent for expo #8

merged 23 commits into from Dec 1, 2022

Conversation

xtreem88
Copy link
Collaborator

This resolves https://github.com/customerio/issues/issues/8574 on Expo config plugin end

Approach

  • Created post-install script
  • After the package is installed, post-install script checks if customerio-reactnative is installed
  • If found, read the current package.json and get version
  • set expoVersion in customerio-reactnative's package.json file and save

@xtreem88 xtreem88 changed the title 8574 fix user agent issue for expo feat: user agent for expo Nov 17, 2022
levibostian
levibostian reviewed Nov 17, 2022
View reviewed changes
src/postInstall.js Outdated Show resolved Hide resolved
src/postInstall.js Outdated Show resolved Hide resolved
levibostian
levibostian reviewed Nov 28, 2022
View reviewed changes
package-lock.json Show resolved Hide resolved
src/postInstall.js Outdated Show resolved Hide resolved
matt-frizzell
matt-frizzell reviewed Nov 29, 2022
View reviewed changes
src/postInstall.js Outdated Show resolved Hide resolved
@xtreem88
Cleaned up user agent code (#14)
4c984b1 
Cleaned up user agent code
levibostian
levibostian reviewed Nov 30, 2022
View reviewed changes
src/version.ts Outdated Show resolved Hide resolved
@customerio customerio deleted a comment from xtreem88 Nov 30, 2022
@ami-oss-ci
Copy link

ami-oss-ci commented Nov 30, 2022 •
edited

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@xtreem88 xtreem88 merged commit 19e78b1 into develop Dec 1, 2022
@xtreem88 xtreem88 deleted the 8574-fix-user-agent-issue-for-expo branch December 1, 2022 06:32
ami-ci pushed a commit that referenced this pull request Dec 30, 2022
@semantic-release-bot
chore: prepare for 1.0.0-alpha.6
4c58d2c 
## [1.0.0-alpha.6](1.0.0-alpha.5...1.0.0-alpha.6) (2022-12-30)

### ⚠ BREAKING CHANGES

* changed googleServicesFilePath to googleServicesFile (#16)

### Features

* fixed issues with adding file to target ([#10](#10)) ([0674c66](0674c66))
* rich push environment variable setup ([#23](#23)) ([8d83c95](8d83c95))
* user agent for expo ([#8](#8)) ([19e78b1](19e78b1))

### Code Refactoring

* changed googleServicesFilePath to googleServicesFile ([#16](#16)) ([26be4db](26be4db))
@ami-ci
Copy link
Contributor

ami-ci commented Dec 30, 2022

🎉 This PR is included in version 1.0.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ami-ci pushed a commit that referenced this pull request Dec 30, 2022
@semantic-release-bot
chore: prepare for 1.0.0-beta.1
795e69b 
## 1.0.0-beta.1 (2022-12-30)

### ⚠ BREAKING CHANGES

* changed googleServicesFilePath to googleServicesFile (#16)

### Features

* added ability to set use_frameworks to static ([#9](#9)) ([05d7012](05d7012))
* fixed issues with adding file to target ([#10](#10)) ([0674c66](0674c66))
* rich push environment variable setup ([#23](#23)) ([8d83c95](8d83c95))
* user agent for expo ([#8](#8)) ([19e78b1](19e78b1))

### Bug Fixes

* fixed info.plist formatting issue ([#18](#18)) ([d701794](d701794))
* update .releaserc.json ([#21](#21)) ([8c751cf](8c751cf))
* updated package version ([#19](#19)) ([ab30383](ab30383))

### Code Refactoring

* changed googleServicesFilePath to googleServicesFile ([#16](#16)) ([26be4db](26be4db))
@ami-ci
Copy link
Contributor

ami-ci commented Dec 30, 2022

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-frizzell matt-frizzell matt-frizzell left review comments

@levibostian levibostian levibostian approved these changes

@ami-aman ami-aman Awaiting requested review from ami-aman

@mrehan27 mrehan27 Awaiting requested review from mrehan27

@Shahroz16 Shahroz16 Awaiting requested review from Shahroz16

Assignees
No one assigned
Labels
released on @alpha released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xtreem88 @ami-oss-ci @ami-ci @levibostian @matt-frizzell