fix: added proguard rules for R8 strict mode #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shahroz16
commented
Apr 8, 2024
| @@ -2,14 +2,14 @@ group 'io.customer.customer_io' | |||
| version '1.0-SNAPSHOT' | |||
|
|
|||
| buildscript { | |||
| ext.kotlin_version = '1.6.10' | |||
| ext.kotlin_version = '1.7.21' | |||
There was a problem hiding this comment.
these are matching the android SDK versions
| @@ -16,7 +16,7 @@ dependencies: | |||
| dev_dependencies: | |||
| flutter_test: | |||
| sdk: flutter | |||
| flutter_lints: ^2.0.0 | |||
| flutter_lints: ^3.0.2 | |||
There was a problem hiding this comment.
this is a dev dependency
|
|
||
| import 'package:customer_io/customer_io.dart'; | ||
| import 'package:customer_io/customer_io_inapp.dart'; | ||
| import 'package:firebase_core/firebase_core.dart'; |
mrehan27
approved these changes
Apr 8, 2024
| @@ -78,7 +68,7 @@ flutter { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.21" | |||
There was a problem hiding this comment.
I think we should avoid hardcoding versions, as they are error-prone and harder to track when updating,
There was a problem hiding this comment.
agreed, left it for gradle 8 changes to not complicate this one.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## [1.3.2](1.3.1...1.3.2) (2024-04-08) ### Bug Fixes * added proguard rules for R8 strict mode ([#116](#116)) ([9946fe7](9946fe7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps: MBL-229 : Proguard rules for Android
What it does: