Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify in-app event listener action parameters to new name #255

Merged
merged 23 commits into from Jan 30, 2023

Conversation

levibostian
Copy link
Member

@levibostian levibostian commented Jan 30, 2023

@levibostian levibostian requested a review from a team January 30, 2023 18:05
@ami-oss-ci
Copy link

ami-oss-ci commented Jan 30, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #255 (8e2bd3b) into develop (acd12da) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #255   +/-   ##
========================================
  Coverage    56.11%   56.11%           
========================================
  Files          103      103           
  Lines         1153     1153           
========================================
  Hits           647      647           
  Misses         506      506           
Impacted Files Coverage Δ
.../MessagingInApp/MessagingInAppImplementation.swift 78.57% <ø> (ø)
...ngInApp/autogenerated/AutoMockable.generated.swift 89.18% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ami-oss-ci
Copy link

ami-oss-ci commented Jan 30, 2023

Warnings
⚠️

I noticed file Tests/MessagingInApp/APITest.swift was modified. That could mean that this pull request is introducing a breaking change to the SDK.

If this pull request does introduce a breaking change, make sure the pull request title is in the format:

<type>!: description of breaking change 
// Example:
refactor!: remove onComplete callback from async functions 

Generated by 🚫 dangerJS against 8e2bd3b

Base automatically changed from levi/in-app-no-org-id to develop January 30, 2023 19:09
@levibostian levibostian merged commit b46528a into develop Jan 30, 2023
@levibostian levibostian deleted the levi/action-name-inapp-edit branch January 30, 2023 19:54
github-actions bot pushed a commit that referenced this pull request Feb 7, 2023
## [2.1.0-beta.1](2.0.4...2.1.0-beta.1) (2023-02-07)

### Features

* add in-app event listener ([#211](#211)) ([737d43b](737d43b))
* in-app feature no longer requires orgId ([#252](#252)) ([acd12da](acd12da))

### Bug Fixes

* added reusable code for wrapper SDKs ([#247](#247)) ([36adf15](36adf15))
* in-app missing event ([#259](#259)) ([43b3e97](43b3e97))
* modify in-app event listener action parameters to new name ([#255](#255)) ([b46528a](b46528a))
* region visibility modifier to be used by wrappers ([#260](#260)) ([f0edfbc](f0edfbc))
* update the gist version in podspec ([#256](#256)) ([5451488](5451488))
github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
## [2.1.0](2.0.6...2.1.0) (2023-02-22)

### Features

* add in-app event listener ([#211](#211)) ([737d43b](737d43b))
* in-app feature no longer requires orgId ([#252](#252)) ([acd12da](acd12da))

### Bug Fixes

* access modifier for metric ([#263](#263)) ([e641982](e641982))
* added reusable code for wrapper SDKs ([#247](#247)) ([36adf15](36adf15))
* in-app missing event ([#259](#259)) ([43b3e97](43b3e97))
* modify in-app event listener action parameters to new name ([#255](#255)) ([b46528a](b46528a))
* region visibility modifier to be used by wrappers ([#260](#260)) ([f0edfbc](f0edfbc))
* update the gist version in podspec ([#256](#256)) ([5451488](5451488))
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to nagyist/customerio-ios that referenced this pull request Feb 23, 2023
## [2.0.0](1.2.4...2.0.0) (2023-02-23)

### ⚠ BREAKING CHANGES

* make delivered push metric more reliable
* remove FCM dependency from cocoapods (customerio#210)
* singleton API only way to use SDK now (customerio#209)

### Features

* add in-app event listener ([customerio#211](https://github.com/nagyist/customerio-ios/issues/211)) ([737d43b](737d43b))
* in-app feature no longer requires orgId ([customerio#252](https://github.com/nagyist/customerio-ios/issues/252)) ([acd12da](acd12da))

### Bug Fixes

* access modifier for metric ([customerio#263](https://github.com/nagyist/customerio-ios/issues/263)) ([e641982](e641982))
* add sdkwrapperconfig to rich push SDK config ([customerio#226](https://github.com/nagyist/customerio-ios/issues/226)) ([e43b4cf](e43b4cf))
* added reusable code for wrapper SDKs ([customerio#247](https://github.com/nagyist/customerio-ios/issues/247)) ([36adf15](36adf15))
* async running BQ operations in loop ([customerio#250](https://github.com/nagyist/customerio-ios/issues/250)) ([f0a3d9c](f0a3d9c))
* device attributes shows sdk version instead of wrapper version ([e2462b9](e2462b9))
* do not modify custom attributes casing ([customerio#234](https://github.com/nagyist/customerio-ios/issues/234)) ([8160fdf](8160fdf))
* download rich push images from CDN ([customerio#237](https://github.com/nagyist/customerio-ios/issues/237)) ([b30cf02](b30cf02))
* fix compile time errors notification service extensions ([customerio#214](https://github.com/nagyist/customerio-ios/issues/214)) ([bd5911b](bd5911b))
* fix compile time errors notification service extensions ([customerio#216](https://github.com/nagyist/customerio-ios/issues/216)) ([6e8484a](6e8484a))
* in-app missing event ([customerio#259](https://github.com/nagyist/customerio-ios/issues/259)) ([43b3e97](43b3e97))
* make delivered push metric more reliable ([0478e52](0478e52))
* modify in-app event listener action parameters to new name ([customerio#255](https://github.com/nagyist/customerio-ios/issues/255)) ([b46528a](b46528a))
* prevent stackoverflow while executing background queue with lots of tasks in it ([customerio#245](https://github.com/nagyist/customerio-ios/issues/245)) ([ef0c428](ef0c428))
* push images and processing simple push ([customerio#230](https://github.com/nagyist/customerio-ios/issues/230)) ([f109f04](f109f04))
* region visibility modifier to be used by wrappers ([customerio#260](https://github.com/nagyist/customerio-ios/issues/260)) ([f0edfbc](f0edfbc))
* revert 2.0.2 as it was found unstable ([customerio#249](https://github.com/nagyist/customerio-ios/issues/249)) ([51b5831](51b5831))
* sdk not able to compile in ios app ([customerio#225](https://github.com/nagyist/customerio-ios/issues/225)) ([e4d1b3f](e4d1b3f))
* universal links deep links open host app ([customerio#268](https://github.com/nagyist/customerio-ios/issues/268)) ([29c95b5](29c95b5))
* universal links when touch a push notification open host app ([customerio#265](https://github.com/nagyist/customerio-ios/issues/265)) ([7dcaf73](7dcaf73))
* update the gist version in podspec ([customerio#256](https://github.com/nagyist/customerio-ios/issues/256)) ([5451488](5451488))

### Code Refactoring

* remove FCM dependency from cocoapods ([customerio#210](https://github.com/nagyist/customerio-ios/issues/210)) ([3547076](3547076))
* singleton API only way to use SDK now ([customerio#209](https://github.com/nagyist/customerio-ios/issues/209)) ([72b7477](72b7477))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants