Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in app click tracking #284

Merged
merged 9 commits into from Apr 19, 2023
Merged

feat: in app click tracking #284

merged 9 commits into from Apr 19, 2023

Conversation

Shahroz16
Copy link
Contributor

closes: https://github.com/customerio/issues/issues/8658

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Hey, there @Shahroz16 👋🤖. I'm a bot here to help you.

⚠️ Pull requests into the branch main typically only allows changes with the types: fix. From the pull request title, the type of change this pull request is trying to complete is: feat. ⚠️

This pull request might still be allowed to be merged. However, you might want to consider make this pull request merge into a different branch other then main.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@Shahroz16 Shahroz16 requested a review from a team April 12, 2023 17:53
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #284 (34a6b5f) into main (303ef55) will increase coverage by 0.22%.
The diff coverage is 80.00%.

❗ Current head 34a6b5f differs from pull request most recent head 82fde24. Consider uploading reports for the commit 82fde24 to get more accurate results

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   56.01%   56.24%   +0.22%     
==========================================
  Files         105      105              
  Lines        1180     1177       -3     
==========================================
+ Hits          661      662       +1     
+ Misses        519      515       -4     
Impacted Files Coverage Δ
Sources/Common/Service/HttpClient.swift 88.88% <ø> (ø)
...ogenerated/AutoDependencyInjection.generated.swift 100.00% <ø> (ø)
...es/Common/autogenerated/AutoLenses.generated.swift 13.15% <ø> (ø)
.../MessagingInApp/MessagingInAppImplementation.swift 78.57% <ø> (ø)
...ogenerated/AutoDependencyInjection.generated.swift 40.00% <ø> (ø)
...gingInApp/autogenerated/AutoLenses.generated.swift 0.00% <ø> (ø)
...ngInApp/autogenerated/AutoMockable.generated.swift 89.18% <ø> (ø)
...ogenerated/AutoDependencyInjection.generated.swift 0.00% <ø> (ø)
...agingPush/autogenerated/AutoLenses.generated.swift 14.28% <ø> (ø)
...ingPush/autogenerated/AutoMockable.generated.swift 0.00% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments I have about this PR are identical to the Android PR. I'll approve once those conversations are resolved there and decisions are replicated on this PR.

Tests/Common/Background Queue/QueueTest.swift Outdated Show resolved Hide resolved
@Shahroz16 Shahroz16 merged commit 4ed8edb into main Apr 19, 2023
9 of 12 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/in-app-click-tracking branch April 19, 2023 21:38
github-actions bot pushed a commit that referenced this pull request Apr 19, 2023
## [2.3.0](2.2.0...2.3.0) (2023-04-19)

### Features

* in app click tracking ([#284](#284)) ([4ed8edb](4ed8edb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants